[gnome-software/wip/hughsie/unique_id] f



commit cb13c81b1656c733552d61a00cf9bfa218aaa9bd
Author: Richard Hughes <richard hughsie com>
Date:   Fri Jul 29 16:20:03 2016 +0100

    f

 src/plugins/gs-plugin-appstream.c  |    5 ++---
 src/plugins/gs-plugin-key-colors.c |    4 +++-
 2 files changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/src/plugins/gs-plugin-appstream.c b/src/plugins/gs-plugin-appstream.c
index d4a7946..adc3a9e 100644
--- a/src/plugins/gs-plugin-appstream.c
+++ b/src/plugins/gs-plugin-appstream.c
@@ -321,9 +321,8 @@ gs_plugin_refine_from_id (GsPlugin *plugin,
        item = as_store_get_app_by_unique_id (priv->store, unique_id);
        if (item == NULL) {
                const gchar *id = gs_app_get_id (app);
-               g_debug ("looking for fallback of %s", unique_id);
-               if (g_strcmp0 (unique_id, id) != 0)
-                       item = as_store_get_app_by_id (priv->store, id);
+               g_debug ("looking for fallback of %s", id);
+               item = as_store_get_app_by_id (priv->store, id);
        }
        if (item == NULL) {
                g_debug ("no app with ID %s found in appstream", unique_id);
diff --git a/src/plugins/gs-plugin-key-colors.c b/src/plugins/gs-plugin-key-colors.c
index b3b32d1..65f31ea 100644
--- a/src/plugins/gs-plugin-key-colors.c
+++ b/src/plugins/gs-plugin-key-colors.c
@@ -175,8 +175,10 @@ gs_plugin_refine_app (GsPlugin *plugin,
 
        /* no pixbuf */
        pb = gs_app_get_pixbuf (app);
-       if (pb == NULL)
+       if (pb == NULL) {
+               g_debug ("no pixbuf, so no key colors");
                return TRUE;
+       }
 
        /* get a list of key colors */
        pb_small = gdk_pixbuf_scale_simple (pb, 32, 32, GDK_INTERP_BILINEAR);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]