[pitivi] widgets: Concider user provided prop value has overriding default ones



commit 800c5a37072a0c945e1da24696bda50b825bc1eb
Author: Thibault Saunier <tsaunier gnome org>
Date:   Thu Jul 28 09:45:31 2016 -0400

    widgets: Concider user provided prop value has overriding default ones
    
    Otherwise we end up using 'None' for many fields in the element
    properties widget instead of the default value.
    
    Reviewed-by: Alex Băluț <alexandru balut gmail com>
    Differential Revision: https://phabricator.freedesktop.org/D1222

 pitivi/utils/widgets.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/pitivi/utils/widgets.py b/pitivi/utils/widgets.py
index 5c9b395..1902ca7 100644
--- a/pitivi/utils/widgets.py
+++ b/pitivi/utils/widgets.py
@@ -664,11 +664,11 @@ class GstElementSettingsWidget(Gtk.Box, Loggable):
                     self.debug(
                         "Could not get value for property: %s", prop.name)
             else:
-                if not values:
+                if prop.name not in values.keys():
                     # Use the default value.
                     prop_value = self.element.get_property(prop.name)
                 else:
-                    prop_value = values.get(prop.name)
+                    prop_value = values[prop.name]
 
             widget = self._makePropertyWidget(prop, prop_value)
             if isinstance(widget, ToggleWidget):


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]