[polari/wip/raresv/popoverRebasedOnTracker] popover has fixed height and the fullname label is not hidden anymore, just its text is set to empty



commit 124eab5080a06dd2ead04b1b61f63028219f1588
Author: raresv <rares visalom gmail com>
Date:   Mon Jul 25 14:28:16 2016 +0300

    popover has fixed height and the fullname label is not hidden anymore, just its text is set to empty when 
in the offline case, thus preventing its space from being 'squashed' when it is hidden.

 data/resources/user-popover.ui |    1 +
 src/userList.js                |    3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/data/resources/user-popover.ui b/data/resources/user-popover.ui
index 8baed46..63e91e4 100644
--- a/data/resources/user-popover.ui
+++ b/data/resources/user-popover.ui
@@ -3,6 +3,7 @@
   <template class="Gjs_UserPopover" parent="GtkPopover">
     <property name="hexpand">False</property>
     <property name="width-request">280</property>
+    <property name="height-request">220</property>
     <child>
       <object class="GtkBox">
         <property name="orientation">vertical</property>
diff --git a/src/userList.js b/src/userList.js
index e34c823..628a6d0 100644
--- a/src/userList.js
+++ b/src/userList.js
@@ -267,7 +267,6 @@ const UserDetails = new Lang.Class({
             fn = this._user.alias;
 
         this._fullnameLabel.label = fn;
-        this._fullnameLabel.visible = true;
         this._userIcon.visible = true;
 
         if (last) {
@@ -289,7 +288,7 @@ const UserDetails = new Lang.Class({
         this._lastHeader.show();
 
         this._userIcon.visible = false;
-        this._fullnameLabel.visible = false;
+        this._fullnameLabel.label = "";
 
         this._revealDetails();
     },


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]