[meld/Python3] recent: Remove unicode/bytestring comment
- From: Kai Willadsen <kaiw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [meld/Python3] recent: Remove unicode/bytestring comment
- Date: Sun, 24 Jul 2016 01:48:12 +0000 (UTC)
commit 1b4e8cf41b2e04eb1062dc1f9e2dde40d74bcf43
Author: Kai Willadsen <kai willadsen gmail com>
Date: Sun Jul 24 08:15:21 2016 +1000
recent: Remove unicode/bytestring comment
This comment is for handling the situation where we get filenames with
broken encodings. GTK+ under Python 3 doesn't handle this at all, so we
can't sensibly either.
meld/recent.py | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/meld/recent.py b/meld/recent.py
index 926ab66..5646d3f 100644
--- a/meld/recent.py
+++ b/meld/recent.py
@@ -154,11 +154,6 @@ class RecentFiles(object):
return comp_type, paths, flags
def _write_recent_file(self, comp_type, paths):
- # FIXME: Commenting out this line is 100% incorrect. We need to
- # be storing bytestrings here, but the configparser API doesn't
- # like this. This code *will* eventually break.
- # paths = [p.encode(sys.getfilesystemencoding()) for p in paths]
-
# TODO: Use GKeyFile instead, and return a Gio.File. This is why we're
# using ';' to join comparison paths.
with tempfile.NamedTemporaryFile(
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]