[orca] Remove .desktop file
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Remove .desktop file
- Date: Wed, 20 Jul 2016 19:42:30 +0000 (UTC)
commit 500d4ca4a984b17dcf3e83d4fa796ac62b9cae45
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Wed Jul 20 15:12:10 2016 -0400
Remove .desktop file
Because launching Orca does not cause any window to appear, Orca is
not seen as an "application." Furthermore, Orca can be started via
shortcut (Alt+Super+S) and listens to the "screen-reader-enabled" key
of the "org.gnome.desktop.a11y.applications" schema. Thus the .desktop
file was seen as no longer needed.
That said, just to be safe, we kept the .desktop file and used the
"NotShowIn" property to disable it from appearing in the environments
who didn't want it (e.g. GNOME and Unity). But that proved to be
insufficient because Orca was still showing up in distros' "App Store"
applications, leading to still more discussion about whether app stores
should hack around non-app applications or maintain separate packages
for Orca's .desktop file. All of this for a file which doesn't serve
much purpose for Orca's actual users because in order to launch Orca
from a desktop environment's Applications menu or search functionality,
that menu or search functionality needs to be accessible, which means
Orca needs to already be running.
If there are still distros which needs Orca's .desktop file, those
distros are encouraged to maintain it downstream.
https://bugzilla.gnome.org/show_bug.cgi?id=735761
Makefile.am | 8 +-------
orca.desktop.in | 16 ----------------
po/POTFILES.in | 1 -
3 files changed, 1 insertions(+), 24 deletions(-)
---
diff --git a/Makefile.am b/Makefile.am
index a7e4353..9b9aa7d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -7,8 +7,7 @@ DISTCHECK_CONFIGURE_FLAGS = \
--disable-scrollkeeper
DISTCLEANFILES = \
- orca-autostart.desktop \
- orca.desktop
+ orca-autostart.desktop
gtk_update_icon_cache = gtk-update-icon-cache -f -t $(datadir)/icons/hicolor
@@ -23,10 +22,6 @@ update-icon-cache:
echo "*** $(gtk_update_icon_cache)"; \
fi
-desktopdir = $(datadir)/applications
-desktop_in_files = orca.desktop.in
-desktop_DATA = $(desktop_in_files:.desktop.in=.desktop)
-
autostartdir = $(sysconfdir)/xdg/autostart
autostart_in_files = orca-autostart.desktop.in
autostart_DATA = $(autostart_in_files:.desktop.in=.desktop)
@@ -35,7 +30,6 @@ autostart_DATA = $(autostart_in_files:.desktop.in=.desktop)
EXTRA_DIST = \
$(autostart_in_files) \
- $(desktop_in_files) \
$(icon_DATA) \
ChangeLog \
MAINTAINERS
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 91d4ca9..c208b1f 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -1,7 +1,6 @@
# List of source files containing translatable strings.
# Please keep this file sorted alphabetically.
[encoding: UTF-8]
-orca.desktop.in
orca-autostart.desktop.in
src/orca/braille_rolenames.py
src/orca/brltablenames.py
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]