[polari/wip/fmuellner/window-experiments: 2/24] mainWindow: Do not call show_all() from _init()



commit aaed065fcb216e138ecf9ccabea1c421fb486f1d
Author: Florian MĂźllner <fmuellner gnome org>
Date:   Wed Jul 13 17:30:18 2016 +0200

    mainWindow: Do not call show_all() from _init()
    
    The expected behavior of widgets in GTK+ is to show all internal
    children that should be visible when the widget is shown, but
    leave its own visibility to the parent (or the code that created
    the widgets). Not following that pattern is confusing for any
    widget, but much worse for toplevel windows where the widget's
    visibility directly corresponds to the visibility on screen.

 src/mainWindow.js |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
---
diff --git a/src/mainWindow.js b/src/mainWindow.js
index a46b113..4fb8d9e 100644
--- a/src/mainWindow.js
+++ b/src/mainWindow.js
@@ -202,8 +202,6 @@ const MainWindow = new Lang.Class({
 
         if (this._settings.get_boolean('window-maximized'))
             this.maximize();
-
-        this.show_all();
     },
 
     get subtitle() {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]