[pan2] Fix error found by valgrind: 34, 020 bytes in 24 blocks are definitely lost in loss record 11, 697 of



commit e5ea76fc13a558ebfe51e391037b8db6c7303e28
Author: Olaf Seibert <rhialto falu nl>
Date:   Tue Mar 22 01:01:37 2016 +0100

    Fix error found by valgrind: 34,020 bytes in 24 blocks are definitely lost in loss record 11,697 of 11,705
    
       at 0x4C2BBCF: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
       by 0x569238: UUInitialize (uulib.c:389)
       by 0x532F49: pan::Decoder::do_work() (decoder.cc:138)
       by 0x5682D9: pan::WorkerPool::Worker::worker_thread_func(void*, void*) (worker-pool.cc:74)
       by 0x6D512FD: g_thread_pool_thread_proxy (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4600.2)
       by 0x6D50964: g_thread_proxy (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4600.2)
       by 0x88156A9: start_thread (pthread_create.c:333)
       by 0x8B32E9C: clone (clone.S:109)
    
    lost memory every time a uuencoded binary is decoded.

 uulib/uulib.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/uulib/uulib.c b/uulib/uulib.c
index 1387e51..2d6816d 100644
--- a/uulib/uulib.c
+++ b/uulib/uulib.c
@@ -1193,7 +1193,7 @@ UUCleanUp (void)
   itbd *iter=ftodel, *ptr;
   uulist *liter;
   uufile *fiter;
-  //allomap *aiter;
+  allomap *aiter;
 
   /*
    * delete temporary input files (such as the copy of stdin)
@@ -1262,10 +1262,10 @@ UUCleanUp (void)
    * clean up the malloc'ed stuff
    */
 
-//  for (aiter=toallocate; aiter->ptr; aiter++) {
-//    _FP_free (*(aiter->ptr));
-//    *(aiter->ptr) = NULL;
-//   }
+  for (aiter=toallocate; aiter->ptr; aiter++) {
+    _FP_free (*(aiter->ptr));
+    *(aiter->ptr) = NULL;
+  }
 
   return UURET_OK;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]