[gtk+/portal] Don't leak the D-Bus connection



commit 113e1e562ef93227566ef0b55b6e35f27537de29
Author: Matthias Clasen <mclasen redhat com>
Date:   Wed Jul 6 20:52:37 2016 -0400

    Don't leak the D-Bus connection
    
    I couldn't reproduce the crash that Alex was mentioning here,
    so lets go with the correct unref.

 gtk/gtkfilechoosernativeportal.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/gtk/gtkfilechoosernativeportal.c b/gtk/gtkfilechoosernativeportal.c
index 48deff3..31786cc 100644
--- a/gtk/gtkfilechoosernativeportal.c
+++ b/gtk/gtkfilechoosernativeportal.c
@@ -69,8 +69,7 @@ filechooser_portal_data_free (FilechooserPortalData *data)
     g_dbus_connection_signal_unsubscribe (data->connection,
                                           data->portal_response_signal_id);
 
-  //TODO: This causes a crash in other code. Do we double unref somewhere?
-  // g_object_unref (data->connection);
+  g_object_unref (data->connection);
 
   if (data->grab_widget)
     {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]