[gnome-boxes] remote-machine: Connect to a non-null unconnected display
- From: Zeeshan Ali Khattak <zeeshanak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes] remote-machine: Connect to a non-null unconnected display
- Date: Tue, 5 Jul 2016 14:18:17 +0000 (UTC)
commit 6d7014c501ec1dcf1aa3edf53b14fc997a3a1c6a
Author: Visarion Alexandru <viorel visarion gmail com>
Date: Fri Jul 1 15:52:06 2016 +0300
remote-machine: Connect to a non-null unconnected display
The problem is that, when connecting to a display, we only connect
to it if it hasn't already been created. By doing this, we ignore
the case when a display is created but not connected, which is a
logical scenario and can lead to a grey screen by choosing not to
connect.
This scenario happens already when fetching the display's properties,
now that we keep the display alive if USB devices are available.
To avoid this issue, let's not assume that the device is already
connected just because it has been created.
https://bugzilla.gnome.org/show_bug.cgi?id=744905
src/remote-machine.vala | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/src/remote-machine.vala b/src/remote-machine.vala
index eff4711..0f84d71 100644
--- a/src/remote-machine.vala
+++ b/src/remote-machine.vala
@@ -45,6 +45,9 @@ private class Boxes.RemoteMachine: Boxes.Machine, Boxes.IPropertiesProvider {
display = create_display ();
display.connect_it ();
} else {
+ if (!display.connected)
+ display.connect_it ();
+
show_display ();
display.set_enable_audio (true);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]