[tracker] libtracker-miner: Do not insert partial/empty sparql on error



commit 7c74b48b6ac94048aa9d69ab3fe7f7d42db672c5
Author: Carlos Garnacho <carlosg gnome org>
Date:   Thu Jan 28 16:26:45 2016 +0100

    libtracker-miner: Do not insert partial/empty sparql on error
    
    The check for these errors was done specifically so we could still
    insert (even if incomplete) data on tracker-extract failures, when
    we used to communicate with it directly from tracker-miner-fs.
    
    Nowadays, tracker-extract is a TrackerDecorator, and tracker-miner-fs
    should most likely receive only errors here on ENOENT and other errors
    that affect the file and its info as a whole. In these situations
    we end up with a task with a completely empty sparql string, which
    doesn't help much here.

 src/libtracker-miner/tracker-miner-fs.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/src/libtracker-miner/tracker-miner-fs.c b/src/libtracker-miner/tracker-miner-fs.c
index d2e22eb..5428586 100644
--- a/src/libtracker-miner/tracker-miner-fs.c
+++ b/src/libtracker-miner/tracker-miner-fs.c
@@ -1419,11 +1419,6 @@ item_add_or_update_continue (TrackerMinerFS *fs,
                g_message ("Could not process '%s': %s", uri, error->message);
 
                fs->priv->total_files_notified_error++;
-
-               if (!g_error_matches (error, G_IO_ERROR, G_IO_ERROR_NOT_FOUND) &&
-                   !g_error_matches (error, G_IO_ERROR, G_IO_ERROR_CANCELLED)) {
-                       sparql_task = tracker_sparql_task_new_with_sparql (file, ctxt->builder);
-               }
        } else {
                if (ctxt->urn) {
                        gboolean attribute_update_only;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]