[glib] registrybackend: fix possible mem leak
- From: Ignacio Casal Quinteiro <icq src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib] registrybackend: fix possible mem leak
- Date: Tue, 26 Jan 2016 10:43:45 +0000 (UTC)
commit 8f7aa273dea5d127249cb76d2f8a2ccc43802d28
Author: Ignacio Casal Quinteiro <icq gnome org>
Date: Tue Jan 26 11:42:05 2016 +0100
registrybackend: fix possible mem leak
If the parameters do not validate we would leak the memory.
gio/gregistrysettingsbackend.c | 13 ++++++++-----
1 files changed, 8 insertions(+), 5 deletions(-)
---
diff --git a/gio/gregistrysettingsbackend.c b/gio/gregistrysettingsbackend.c
index 61de5ba..da7ebaf 100644
--- a/gio/gregistrysettingsbackend.c
+++ b/gio/gregistrysettingsbackend.c
@@ -388,17 +388,19 @@ typedef struct
} RegistryCacheItem;
static GNode *
-registry_cache_add_item (GNode *parent,
- gchar *name,
- RegistryValue value,
- gint ref_count)
+registry_cache_add_item (GNode *parent,
+ gchar *name,
+ RegistryValue value,
+ gint ref_count)
{
- RegistryCacheItem *item = g_slice_new (RegistryCacheItem);
+ RegistryCacheItem *item;
GNode *cache_node;
g_return_val_if_fail (name != NULL, NULL);
g_return_val_if_fail (parent != NULL, NULL);
+ item = g_slice_new (RegistryCacheItem);
+
/* Ref count should be the number of watch points above this node */
item->ref_count = ref_count;
@@ -413,6 +415,7 @@ registry_cache_add_item (GNode *parent,
cache_node = g_node_new (item);
g_node_append (parent, cache_node);
+
return cache_node;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]