[gnome-online-accounts] Use g_clear_pointer wherever applicable
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-online-accounts] Use g_clear_pointer wherever applicable
- Date: Fri, 22 Jan 2016 17:35:48 +0000 (UTC)
commit effc5400eeb4d96a4667e4632fe8e79dfc0aa378
Author: Debarshi Ray <debarshir gnome org>
Date: Fri Jan 22 17:27:58 2016 +0100
Use g_clear_pointer wherever applicable
src/daemon/goadaemon.c | 7 ++-----
src/daemon/main.c | 6 ++----
src/goabackend/goaexchangeprovider.c | 6 ++----
src/goabackend/goaimapsmtpprovider.c | 9 +++------
src/goabackend/goakerberosprovider.c | 8 ++------
src/goabackend/goalastfmprovider.c | 6 ++----
src/goabackend/goamediaserverprovider.c | 6 ++----
src/goabackend/goaoauth2provider.c | 3 +--
src/goabackend/goaoauthprovider.c | 9 +++------
src/goabackend/goaowncloudprovider.c | 6 ++----
10 files changed, 21 insertions(+), 45 deletions(-)
---
diff --git a/src/daemon/goadaemon.c b/src/daemon/goadaemon.c
index 78f4ba6..744ad4d 100644
--- a/src/daemon/goadaemon.c
+++ b/src/daemon/goadaemon.c
@@ -951,9 +951,7 @@ get_all_providers_cb (GObject *source,
g_free (group);
g_free (id);
g_free (path);
- if (key_file != NULL)
- g_key_file_free (key_file);
-
+ g_clear_pointer (&key_file, (GDestroyNotify) g_key_file_free);
g_object_unref (data->daemon);
g_object_unref (data->manager);
g_object_unref (data->invocation);
@@ -1115,8 +1113,7 @@ on_account_handle_remove (GoaAccount *account,
out:
g_clear_object (&provider);
g_free (data);
- if (key_file != NULL)
- g_key_file_free (key_file);
+ g_clear_pointer (&key_file, (GDestroyNotify) g_key_file_free);
g_free (group);
g_free (path);
return TRUE; /* invocation was handled */
diff --git a/src/daemon/main.c b/src/daemon/main.c
index 65fb47d..11fbbb1 100644
--- a/src/daemon/main.c
+++ b/src/daemon/main.c
@@ -143,10 +143,8 @@ main (int argc,
#endif
if (name_owner_id != 0)
g_bus_unown_name (name_owner_id);
- if (loop != NULL)
- g_main_loop_unref (loop);
- if (opt_context != NULL)
- g_option_context_free (opt_context);
+ g_clear_pointer (&loop, (GDestroyNotify) g_main_loop_unref);
+ g_clear_pointer (&opt_context, (GDestroyNotify) g_option_context_free);
g_message ("goa-daemon version %s exiting", PACKAGE_VERSION);
diff --git a/src/goabackend/goaexchangeprovider.c b/src/goabackend/goaexchangeprovider.c
index 9efea52..6f9b3fb 100644
--- a/src/goabackend/goaexchangeprovider.c
+++ b/src/goabackend/goaexchangeprovider.c
@@ -729,8 +729,7 @@ add_account (GoaProvider *provider,
g_assert (ret != NULL);
g_free (data.account_object_path);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
g_clear_object (&ews_client);
return ret;
@@ -883,8 +882,7 @@ refresh_account (GoaProvider *provider,
g_propagate_error (error, data.error);
gtk_widget_destroy (dialog);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
g_clear_object (&ews_client);
return ret;
diff --git a/src/goabackend/goaimapsmtpprovider.c b/src/goabackend/goaimapsmtpprovider.c
index 81f7a5a..41cfabe 100644
--- a/src/goabackend/goaimapsmtpprovider.c
+++ b/src/goabackend/goaimapsmtpprovider.c
@@ -442,8 +442,7 @@ ensure_credentials_sync (GoaProvider *provider,
g_free (smtp_password);
g_free (smtp_server);
g_free (smtp_username);
- if (credentials != NULL)
- g_variant_unref (credentials);
+ g_clear_pointer (&credentials, (GDestroyNotify) g_variant_unref);
return ret;
}
@@ -1156,8 +1155,7 @@ add_account (GoaProvider *provider,
g_free (domain);
g_free (data.account_object_path);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
g_clear_object (&imap_auth);
g_clear_object (&smtp_auth);
@@ -1441,8 +1439,7 @@ refresh_account (GoaProvider *provider,
g_free (imap_username);
g_free (smtp_server);
g_free (smtp_username);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
g_clear_object (&imap_auth);
g_clear_object (&smtp_auth);
diff --git a/src/goabackend/goakerberosprovider.c b/src/goabackend/goakerberosprovider.c
index 26b008e..5bf4244 100644
--- a/src/goabackend/goakerberosprovider.c
+++ b/src/goabackend/goakerberosprovider.c
@@ -343,10 +343,7 @@ get_ticket_sync (GoaKerberosProvider *self,
out:
g_clear_object (&ticketing);
g_free (object_path);
-
- if (credentials != NULL)
- g_variant_unref (credentials);
-
+ g_clear_pointer (&credentials, (GDestroyNotify) g_variant_unref);
return ret;
}
@@ -1308,8 +1305,7 @@ start_over:
g_free (request.account_object_path);
g_free (principal);
g_free (principal_for_display);
- if (request.loop != NULL)
- g_main_loop_unref (request.loop);
+ g_clear_pointer (&request.loop, (GDestroyNotify) g_main_loop_unref);
return object;
}
diff --git a/src/goabackend/goalastfmprovider.c b/src/goabackend/goalastfmprovider.c
index aa3945f..928dd63 100644
--- a/src/goabackend/goalastfmprovider.c
+++ b/src/goabackend/goalastfmprovider.c
@@ -737,8 +737,7 @@ add_account (GoaProvider *provider,
g_free (data.access_token);
g_free (data.account_object_path);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
return ret;
}
@@ -868,8 +867,7 @@ refresh_account (GoaProvider *provider,
g_propagate_error (error, data.error);
gtk_widget_destroy (dialog);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_free (data.access_token);
g_clear_object (&data.cancellable);
return ret;
diff --git a/src/goabackend/goamediaserverprovider.c b/src/goabackend/goamediaserverprovider.c
index 67c572d..b0968da 100644
--- a/src/goabackend/goamediaserverprovider.c
+++ b/src/goabackend/goamediaserverprovider.c
@@ -216,8 +216,7 @@ ensure_credentials_sync (GoaProvider *provider,
ret = TRUE;
out:
- if (credentials != NULL)
- g_variant_unref (credentials);
+ g_clear_pointer (&credentials, (GDestroyNotify) g_variant_unref);
return ret;
}
@@ -529,8 +528,7 @@ add_account (GoaProvider *provider,
g_free (data.account_object_path);
g_free (data.friendly_name);
g_free (data.udn);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
return ret;
}
diff --git a/src/goabackend/goaoauth2provider.c b/src/goabackend/goaoauth2provider.c
index 57ee962..0150406 100644
--- a/src/goabackend/goaoauth2provider.c
+++ b/src/goabackend/goaoauth2provider.c
@@ -1546,8 +1546,7 @@ goa_oauth2_provider_get_access_token_sync (GoaOAuth2Provider *provider,
g_free (refresh_token);
g_free (old_refresh_token);
g_free (password);
- if (credentials != NULL)
- g_variant_unref (credentials);
+ g_clear_pointer (&credentials, (GDestroyNotify) g_variant_unref);
g_mutex_unlock (lock);
diff --git a/src/goabackend/goaoauthprovider.c b/src/goabackend/goaoauthprovider.c
index 9899c39..fc9ba4b 100644
--- a/src/goabackend/goaoauthprovider.c
+++ b/src/goabackend/goaoauthprovider.c
@@ -943,8 +943,7 @@ get_tokens_and_identity (GoaOAuthProvider *provider,
g_free (url);
g_free (data.oauth_verifier);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_free (data.access_token);
g_free (data.access_token_secret);
g_free (escaped_request_token);
@@ -1121,8 +1120,7 @@ goa_oauth_provider_add_account (GoaProvider *_provider,
g_free (access_token_secret);
g_free (session_handle);
g_free (data.account_object_path);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
return ret;
}
@@ -1495,8 +1493,7 @@ goa_oauth_provider_get_access_token_sync (GoaOAuthProvider *provider,
g_free (access_token_secret_for_refresh);
g_free (session_handle_for_refresh);
g_free (password);
- if (credentials != NULL)
- g_variant_unref (credentials);
+ g_clear_pointer (&credentials, (GDestroyNotify) g_variant_unref);
g_mutex_unlock (lock);
diff --git a/src/goabackend/goaowncloudprovider.c b/src/goabackend/goaowncloudprovider.c
index 18d57ff..2e3171b 100644
--- a/src/goabackend/goaowncloudprovider.c
+++ b/src/goabackend/goaowncloudprovider.c
@@ -882,8 +882,7 @@ add_account (GoaProvider *provider,
g_free (server);
g_free (uri);
g_free (data.account_object_path);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
g_clear_object (&http_client);
return ret;
@@ -1039,8 +1038,7 @@ refresh_account (GoaProvider *provider,
gtk_widget_destroy (dialog);
g_free (uri);
g_free (uri_webdav);
- if (data.loop != NULL)
- g_main_loop_unref (data.loop);
+ g_clear_pointer (&data.loop, (GDestroyNotify) g_main_loop_unref);
g_clear_object (&data.cancellable);
g_clear_object (&http_client);
return ret;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]