[easytag/wip/core-refactoring: 4/6] Solve a FIXME when changing file extension case



commit 2b3adb11b8ab8028b000851f8d8c9b741c6c6b4a
Author: David King <amigadave amigadave com>
Date:   Fri Jan 15 22:29:02 2016 +0000

    Solve a FIXME when changing file extension case
    
    As the source strings are is ASCII, use g_ascii_strdown() and
    g_ascii_strup() rather than the UTF-8 equivalents.

 src/file.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
---
diff --git a/src/file.c b/src/file.c
index 450728e..5401a99 100644
--- a/src/file.c
+++ b/src/file.c
@@ -1856,11 +1856,10 @@ ET_File_Format_File_Extension (const ET_File *ETFile)
 
     switch (mode)
     {
-        /* FIXME: Should use filename encoding, not UTF-8! */
         case ET_FILENAME_EXTENSION_LOWER_CASE:
-            return g_utf8_strdown (ETFile->ETFileDescription->Extension, -1);
+            return g_ascii_strdown (ETFile->ETFileDescription->Extension, -1);
         case ET_FILENAME_EXTENSION_UPPER_CASE:
-            return g_utf8_strup (ETFile->ETFileDescription->Extension, -1);
+            return g_ascii_strup (ETFile->ETFileDescription->Extension, -1);
         case ET_FILENAME_EXTENSION_NO_CHANGE:
         default:
             return g_strdup (ETFile->ETFileExtension);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]