[gnome-music] albumartcache: Remove check for dup jobs
- From: Carlos Garnacho <carlosg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-music] albumartcache: Remove check for dup jobs
- Date: Sun, 3 Jan 2016 18:25:38 +0000 (UTC)
commit e7f13685989ba13b4e72af0cce1c0ec4434c0c8d
Author: Carlos Garnacho <carlosg gnome org>
Date: Sun Dec 27 13:04:36 2015 +0100
albumartcache: Remove check for dup jobs
This incurs in O(n²) behavior, worsened by the fact that we never
remove iters from the cache. Instead rely on the query returning
unique results.
https://bugzilla.gnome.org/show_bug.cgi?id=760033
gnomemusic/albumArtCache.py | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
---
diff --git a/gnomemusic/albumArtCache.py b/gnomemusic/albumArtCache.py
index 86f502a..1d98602 100644
--- a/gnomemusic/albumArtCache.py
+++ b/gnomemusic/albumArtCache.py
@@ -82,7 +82,6 @@ def _make_icon_frame(pixbuf, path=None):
class AlbumArtCache(GObject.GObject):
instance = None
blacklist = {}
- itr_queue = []
default_icons_cache = {}
default_icon_width = 256
@@ -209,12 +208,6 @@ class AlbumArtCache(GObject.GObject):
return
try:
- # Make sure we don't lookup the same iterators several times
- if itr:
- if itr.user_data in self.itr_queue:
- return
- self.itr_queue.append(itr.user_data)
-
[success, thumb_file] = MediaArt.get_file(artist, album, "album")
if success == False:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]