[gnome-desktop] thumbnail: Demote a log message from WARNING to DEBUG
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-desktop] thumbnail: Demote a log message from WARNING to DEBUG
- Date: Tue, 23 Feb 2016 14:46:49 +0000 (UTC)
commit 75072547f6e1a40bde9fd1746b57f1b379069dca
Author: Debarshi Ray <debarshir gnome org>
Date: Tue Feb 23 02:11:26 2016 +0100
thumbnail: Demote a log message from WARNING to DEBUG
Failure to create a GdkPixbufLoader for a specific MIME type doesn't
necessarily indicate an error. It is possible that the fallback code
would still be able to parse the image data. For example, Canon CR2 RAW
files have the MIME type image/x-canon-cr2. While we don't have a
loader for that specific MIME type, the TIFF loader can still parse the
data.
In case the fallback code failed to parse the image data, we get a
WARNING anyway:
GnomeDesktop-WARNING **: Error creating thumbnail for ...
Having a log message to indicate that we are using the fallback code is
useful for debugging, but there is no need for the WARNING. It can be
extra noise and needlessly interferes with things like
G_DEBUG=fatal-warnings.
https://bugzilla.gnome.org/show_bug.cgi?id=762504
libgnome-desktop/gnome-desktop-thumbnail.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libgnome-desktop/gnome-desktop-thumbnail.c b/libgnome-desktop/gnome-desktop-thumbnail.c
index b2d3b31..3946309 100644
--- a/libgnome-desktop/gnome-desktop-thumbnail.c
+++ b/libgnome-desktop/gnome-desktop-thumbnail.c
@@ -427,7 +427,7 @@ create_loader (GFile *file,
}
if (loader == NULL) {
- g_warning ("Unable to create loader for mime type %s: %s", mime_type, error->message);
+ g_debug ("Unable to create loader for mime type %s: %s", mime_type, error->message);
g_clear_error (&error);
loader = gdk_pixbuf_loader_new ();
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]