[gnome-photos] application, preview-view: Remove app.undo-current
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-photos] application, preview-view: Remove app.undo-current
- Date: Wed, 17 Feb 2016 23:46:37 +0000 (UTC)
commit f9eb38fa28054c2177d31d31ba7fb1838a6e254e
Author: Debarshi Ray <debarshir gnome org>
Date: Thu Feb 18 00:41:07 2016 +0100
application, preview-view: Remove app.undo-current
We are not planning to offer the ability to undo each single edit.
Instead we allow reverting a series of edits. This makes the
app.undo-current entirely useless and, in fact, it is not used at all
at the moment.
src/photos-application.c | 6 ------
src/photos-preview-view.c | 17 -----------------
2 files changed, 0 insertions(+), 23 deletions(-)
---
diff --git a/src/photos-application.c b/src/photos-application.c
index 203b9f8..32a4596 100644
--- a/src/photos-application.c
+++ b/src/photos-application.c
@@ -95,7 +95,6 @@ struct _PhotosApplicationPrivate
GSimpleAction *set_bg_action;
GSimpleAction *set_ss_action;
GSimpleAction *sharpen_action;
- GSimpleAction *undo_action;
GtkWidget *main_window;
PhotosCameraCache *camera_cache;
PhotosSearchContextState *state;
@@ -319,7 +318,6 @@ photos_application_actions_update (PhotosApplication *self)
g_simple_action_set_enabled (priv->insta_action, enable);
g_simple_action_set_enabled (priv->saturation_action, enable);
g_simple_action_set_enabled (priv->sharpen_action, enable);
- g_simple_action_set_enabled (priv->undo_action, enable);
enable = (mode == PHOTOS_WINDOW_MODE_COLLECTIONS
|| mode == PHOTOS_WINDOW_MODE_FAVORITES
@@ -1536,9 +1534,6 @@ photos_application_startup (GApplication *application)
priv->sharpen_action = g_simple_action_new ("sharpen-current", G_VARIANT_TYPE_DOUBLE);
g_action_map_add_action (G_ACTION_MAP (self), G_ACTION (priv->sharpen_action));
- priv->undo_action = g_simple_action_new ("undo-current", NULL);
- g_action_map_add_action (G_ACTION_MAP (self), G_ACTION (priv->undo_action));
-
g_signal_connect_swapped (priv->state->mode_cntrlr,
"window-mode-changed",
G_CALLBACK (photos_application_window_mode_changed),
@@ -1641,7 +1636,6 @@ photos_application_dispose (GObject *object)
g_clear_object (&priv->set_bg_action);
g_clear_object (&priv->set_ss_action);
g_clear_object (&priv->sharpen_action);
- g_clear_object (&priv->undo_action);
g_clear_object (&priv->camera_cache);
g_clear_object (&priv->sel_cntrlr);
g_clear_object (&priv->extract_priority);
diff --git a/src/photos-preview-view.c b/src/photos-preview-view.c
index ac2f2d9..8bdf355 100644
--- a/src/photos-preview-view.c
+++ b/src/photos-preview-view.c
@@ -481,20 +481,6 @@ photos_preview_view_tool_changed (PhotosPreviewView *self, PhotosTool *tool)
static void
-photos_preview_view_undo (PhotosPreviewView *self)
-{
- PhotosBaseItem *item;
-
- item = PHOTOS_BASE_ITEM (photos_base_manager_get_active_object (self->item_mngr));
- if (item == NULL)
- return;
-
- photos_base_item_operation_undo (item);
- photos_base_item_process_async (item, NULL, photos_preview_view_process, self);
-}
-
-
-static void
photos_preview_view_edit_done_pipeline_save (GObject *source_object, GAsyncResult *res, gpointer user_data)
{
PhotosPreviewView *self = PHOTOS_PREVIEW_VIEW (user_data);
@@ -718,9 +704,6 @@ photos_preview_view_init (PhotosPreviewView *self)
action = g_action_map_lookup_action (G_ACTION_MAP (app), "sharpen-current");
g_signal_connect_object (action, "activate", G_CALLBACK (photos_preview_view_sharpen), self,
G_CONNECT_SWAPPED);
-
- action = g_action_map_lookup_action (G_ACTION_MAP (app), "undo-current");
- g_signal_connect_object (action, "activate", G_CALLBACK (photos_preview_view_undo), self,
G_CONNECT_SWAPPED);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]