[gnome-maps] osmEdit: Fix the flow of signing in and going straight to add/edit



commit 7b7847e5077389a6933636750fe55d35fe8b1b96
Author: Marcus Lundblad <ml update uu se>
Date:   Sun Feb 14 22:55:38 2016 +0100

    osmEdit: Fix the flow of signing in and going straight to add/edit
    
    After re-writing the dialog code to use the 'response' signal instead
    of dialog.response() the first argument to the signal handler was lost,
    resulting in the response codes being mis-interpreted and the next
    dialog not being shown.

 src/contextMenu.js |    4 ++--
 src/placeBubble.js |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/contextMenu.js b/src/contextMenu.js
index eb6ff0b..874414b 100644
--- a/src/contextMenu.js
+++ b/src/contextMenu.js
@@ -146,7 +146,7 @@ const ContextMenu = new Lang.Class({
             let dialog = osmEdit.createAccountDialog(this.get_toplevel(), true);
 
             dialog.show();
-            dialog.connect('response', (function (response) {
+            dialog.connect('response', (function(dialog, response) {
                 dialog.destroy();
                 if (response === OSMAccountDialog.Response.SIGNED_IN)
                     this._addOSMLocation();
@@ -175,7 +175,7 @@ const ContextMenu = new Lang.Class({
                                       this._latitude, this._longitude);
 
         dialog.show();
-        dialog.connect('response', (function (response) {
+        dialog.connect('response', (function(dialog, response) {
             dialog.destroy();
             if (response === OSMEditDialog.Response.UPLOADED) {
                 Application.notificationManager.showMessage(
diff --git a/src/placeBubble.js b/src/placeBubble.js
index 618938e..e694138 100644
--- a/src/placeBubble.js
+++ b/src/placeBubble.js
@@ -239,7 +239,7 @@ const PlaceBubble = new Lang.Class({
             let dialog = osmEdit.createAccountDialog(this.get_toplevel(), true);
 
             dialog.show();
-            dialog.connect('response', (function(response) {
+            dialog.connect('response', (function(dialog, response) {
                 dialog.destroy();
                 if (response === OSMAccountDialog.Response.SIGNED_IN)
                     this._edit();
@@ -256,7 +256,7 @@ const PlaceBubble = new Lang.Class({
         let dialog = osmEdit.createEditDialog(this.get_toplevel(), this._place);
 
         dialog.show();
-        dialog.connect('response', (function(response) {
+        dialog.connect('response', (function(dialog, response) {
             dialog.destroy();
 
             switch (response) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]