[evolution/gnome-3-18] EHTMLEditorUtils - prev_parent variable can be used uninitialized
- From: Tomas Popela <tpopela src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution/gnome-3-18] EHTMLEditorUtils - prev_parent variable can be used uninitialized
- Date: Fri, 12 Feb 2016 10:15:38 +0000 (UTC)
commit 37551599b8fa53a6ee2a3e519b3d1c3d6f4c8d43
Author: Tomas Popela <tpopela redhat com>
Date: Fri Feb 12 10:38:27 2016 +0100
EHTMLEditorUtils - prev_parent variable can be used uninitialized
e-util/e-html-editor-utils.c | 16 +++++++++-------
1 files changed, 9 insertions(+), 7 deletions(-)
---
diff --git a/e-util/e-html-editor-utils.c b/e-util/e-html-editor-utils.c
index e18ef7f..7a840d5 100644
--- a/e-util/e-html-editor-utils.c
+++ b/e-util/e-html-editor-utils.c
@@ -321,7 +321,7 @@ split_node_into_two (WebKitDOMNode *item,
gint current_level = 1;
WebKitDOMDocument *document;
WebKitDOMDocumentFragment *fragment;
- WebKitDOMNode *parent, *prev_parent, *tmp;
+ WebKitDOMNode *parent, *prev_parent = NULL, *tmp = NULL;
document = webkit_dom_node_get_owner_document (item);
fragment = webkit_dom_document_create_document_fragment (document);
@@ -366,12 +366,14 @@ split_node_into_two (WebKitDOMNode *item,
current_level++;
}
- tmp = webkit_dom_node_insert_before (
- parent,
- webkit_dom_node_get_first_child (WEBKIT_DOM_NODE (fragment)),
- webkit_dom_node_get_next_sibling (prev_parent),
- NULL);
- remove_node_if_empty (prev_parent);
+ if (prev_parent) {
+ tmp = webkit_dom_node_insert_before (
+ parent,
+ webkit_dom_node_get_first_child (WEBKIT_DOM_NODE (fragment)),
+ webkit_dom_node_get_next_sibling (prev_parent),
+ NULL);
+ remove_node_if_empty (prev_parent);
+ }
return tmp;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]