[gnome-software/wip/rancell/reviews] Revert "Simplify set_review_usefulness ()"



commit 43f86333d75d7274435ccec063c7bfd96f92eb6b
Author: Robert Ancell <robert ancell canonical com>
Date:   Fri Feb 12 13:14:26 2016 +1300

    Revert "Simplify set_review_usefulness ()"
    
    This reverts commit 4ff9047ed15614adf482bff79de12f73bb223d85.

 src/plugins/gs-plugin-ubuntu-reviews.c |   32 ++++++++++++++------------------
 1 files changed, 14 insertions(+), 18 deletions(-)
---
diff --git a/src/plugins/gs-plugin-ubuntu-reviews.c b/src/plugins/gs-plugin-ubuntu-reviews.c
index be5a9fa..3969d24 100644
--- a/src/plugins/gs-plugin-ubuntu-reviews.c
+++ b/src/plugins/gs-plugin-ubuntu-reviews.c
@@ -964,26 +964,22 @@ set_review_usefulness (GsPlugin *plugin,
 {
        GsPluginPrivate *priv = plugin->priv;
        g_autofree gchar *uri;
+       g_autoptr(SoupMessage) msg;
        guint status_code;
 
-       /* Send message to reviews server */
-       uri = g_strdup_printf ("/api/1.0/reviews/%s/recommendations/?useful=%s", review_id, is_useful ? 
"True" : "False");
-       send_signed_request (priv->session,
-                            UBUNTU_REVIEWS_SERVER,
-                            SOUP_METHOD_POST,
-                            uri,
-                            NULL,
-                            NULL,
-                            OA_PLAINTEXT,
-                            priv->consumer_key,
-                            priv->consumer_secret,
-                            priv->token_key,
-                            priv->token_secret,
-                            error);
+       /* Create message for reviews.ubuntu.com */
+       uri = g_strdup_printf ("%s/api/1.0/reviews/%s/recommendations/?useful=%s", UBUNTU_REVIEWS_SERVER, 
review_id, is_useful ? "True" : "False");
+       msg = soup_message_new (SOUP_METHOD_POST, uri);
+       sign_message (msg,
+                     OA_PLAINTEXT,
+                     priv->consumer_key,
+                     priv->consumer_secret,
+                     priv->token_key,
+                     priv->token_secret);
 
-       if (error != NULL && *error != NULL) {
-               return FALSE;
-       } else if (status_code != SOUP_STATUS_OK) {
+       /* Send to the server */
+       status_code = soup_session_send_message (priv->session, msg);
+       if (status_code != SOUP_STATUS_OK) {
                g_set_error (error,
                             GS_PLUGIN_ERROR,
                             GS_PLUGIN_ERROR_FAILED,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]