[gnome-software/wip/rancell/reviews] Correctly set origin and distroseries
- From: Robert Ancell <rancell src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/wip/rancell/reviews] Correctly set origin and distroseries
- Date: Thu, 11 Feb 2016 02:34:29 +0000 (UTC)
commit 494cdf565622690619c5c1e38a474b432db6467b
Author: Robert Ancell <robert ancell canonical com>
Date: Thu Feb 11 15:32:30 2016 +1300
Correctly set origin and distroseries
src/plugins/gs-plugin-ubuntu-reviews.c | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
---
diff --git a/src/plugins/gs-plugin-ubuntu-reviews.c b/src/plugins/gs-plugin-ubuntu-reviews.c
index 4341944..e41b110 100644
--- a/src/plugins/gs-plugin-ubuntu-reviews.c
+++ b/src/plugins/gs-plugin-ubuntu-reviews.c
@@ -31,6 +31,7 @@
#include <gs-utils.h>
#include "gs-ubuntu-login-dialog.h"
+#include "gs-os-release.h"
struct GsPluginPrivate {
gchar *db_path;
@@ -750,7 +751,7 @@ set_package_review (GsPlugin *plugin,
GsPluginPrivate *priv = plugin->priv;
gint rating;
gint n_stars;
- g_autofree gchar *uri;
+ g_autofree gchar *uri = NULL, *os_id = NULL, *os_ubuntu_codename = NULL;
g_autoptr(SoupMessage) msg;
JsonBuilder *builder;
guint status_code;
@@ -768,6 +769,13 @@ set_package_review (GsPlugin *plugin,
else
n_stars = 1;
+ os_id = gs_os_release_get_id (error);
+ if (os_id == NULL)
+ return FALSE;
+ os_ubuntu_codename = gs_os_release_get ("UBUNTU_CODENAME", error);
+ if (os_ubuntu_codename == NULL)
+ return FALSE;
+
/* Create message for reviews.ubuntu.com */
uri = g_strdup_printf ("%s/api/1.0/reviews/", UBUNTU_REVIEWS_SERVER);
msg = soup_message_new (SOUP_METHOD_POST, uri);
@@ -777,8 +785,8 @@ set_package_review (GsPlugin *plugin,
add_string_member (builder, "summary", gs_review_get_summary (review));
add_string_member (builder, "review_text", gs_review_get_text (review));
add_string_member (builder, "language", "en"); // FIXME
- add_string_member (builder, "origin", "ubuntu"); // FIXME gs_app_get_origin (app));
- add_string_member (builder, "distroseries", "xenial"); // FIXME
+ add_string_member (builder, "origin", os_id);
+ add_string_member (builder, "distroseries", os_ubuntu_codename);
add_string_member (builder, "version", gs_review_get_version (review));
add_int_member (builder, "rating", n_stars);
add_string_member (builder, "arch_tag", "amd64"); // FIXME
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]