[epiphany] web-view: Remove ge_modal_alert signal
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] web-view: Remove ge_modal_alert signal
- Date: Wed, 10 Feb 2016 14:04:46 +0000 (UTC)
commit ea93a62712be6812f055f5522b2a91c3f11acf84
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Tue Feb 9 13:34:21 2016 -0600
web-view: Remove ge_modal_alert signal
It's connected to, but never emitted
https://bugzilla.gnome.org/show_bug.cgi?id=755585
embed/ephy-web-view.c | 16 ----------------
src/ephy-window.c | 27 ---------------------------
2 files changed, 0 insertions(+), 43 deletions(-)
---
diff --git a/embed/ephy-web-view.c b/embed/ephy-web-view.c
index 961aebe..64d67a8 100644
--- a/embed/ephy-web-view.c
+++ b/embed/ephy-web-view.c
@@ -1102,22 +1102,6 @@ ephy_web_view_class_init (EphyWebViewClass *klass)
GTK_TYPE_WIDGET);
/**
- * EphyWebView::ge-modal-alert:
- * @view: the #EphyWebView that received the signal
- *
- * The ::ge-modal-alert signal is emitted when a DOM event will open a
- * modal alert.
- *
- * Return %TRUE to prevent the dialog from being opened.
- **/
- g_signal_new ("ge_modal_alert",
- EPHY_TYPE_WEB_VIEW,
- G_SIGNAL_RUN_LAST,
- 0, g_signal_accumulator_true_handled, NULL, NULL,
- G_TYPE_BOOLEAN,
- 0);
-
-/**
* EphyWebView::search-key-press:
* @view: the #EphyWebView that received the signal
* @event: the #GdkEventKey which triggered this signal
diff --git a/src/ephy-window.c b/src/ephy-window.c
index 61debfb..3735dd9 100644
--- a/src/ephy-window.c
+++ b/src/ephy-window.c
@@ -2537,27 +2537,6 @@ ephy_window_set_active_tab (EphyWindow *window, EphyEmbed *new_embed)
ephy_window_connect_active_embed (window);
}
-static gboolean
-embed_modal_alert_cb (EphyEmbed *embed,
- EphyWindow *window)
-{
- const char *address;
-
- /* switch the window to the tab, and bring the window to the foreground
- * (since the alert is modal, the user won't be able to do anything
- * with his current window anyway :|)
- */
- impl_set_active_child (EPHY_EMBED_CONTAINER (window), embed);
- gtk_window_present (GTK_WINDOW (window));
-
- /* make sure the location entry shows the real URL of the tab's page */
- address = ephy_web_view_get_display_address (ephy_embed_get_web_view (embed));
- ephy_window_set_location (window, address);
-
- /* don't suppress alert */
- return FALSE;
-}
-
static void
tab_accels_item_activate (GtkAction *action,
EphyWindow *window)
@@ -2760,9 +2739,6 @@ notebook_page_added_cb (EphyNotebook *notebook,
g_signal_connect_object (ephy_embed_get_web_view (embed), "download-only-load",
G_CALLBACK (download_only_load_cb), window, G_CONNECT_AFTER);
- g_signal_connect_object (ephy_embed_get_web_view (embed), "ge-modal-alert",
- G_CALLBACK (embed_modal_alert_cb), window, G_CONNECT_AFTER);
-
if (priv->present_on_insert)
{
priv->present_on_insert = FALSE;
@@ -2795,9 +2771,6 @@ notebook_page_removed_cb (EphyNotebook *notebook,
g_signal_handlers_disconnect_by_func
(ephy_embed_get_web_view (embed), G_CALLBACK (download_only_load_cb), window);
- g_signal_handlers_disconnect_by_func
- (ephy_embed_get_web_view (embed), G_CALLBACK (embed_modal_alert_cb), window);
-
tab_accels_update (window);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]