[libgsf] Fix some criticals.



commit 74de40f1fa6708c9e87c0b556ff798ea22e986b6
Author: Jean Brefort <jean brefort normalesup org>
Date:   Tue Feb 9 16:05:09 2016 +0100

    Fix some criticals.

 ChangeLog            |    6 ++++++
 NEWS                 |    3 +++
 gsf/gsf-output-gio.c |    6 ------
 3 files changed, 9 insertions(+), 6 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index a3cb0f5..29f17e9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2016-02-09  Jean Brefort  <jean brefort normalesup org>
+
+       * gsf/gsf-output-gio.c (gsf_output_gio_new_full),
+       (gsf_output_gio_close), (gsf_output_gio_init): Remove the unused GFile
+       member. Fix a few criticals.
+
 2016-02-06  Morten Welinder  <terra gnome org>
 
        * gsf/gsf-open-pkg-utils.c (gsf_open_pkg_open_rel): Move
diff --git a/NEWS b/NEWS
index 7e35055..c7c9ded 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,8 @@
 libgsf 1.14.36
 
+Jean:
+       * Fix some criticals.
+
 Morten:
        * Plug leak
        * Fix openpkg absolute member reference.  [#761648]
diff --git a/gsf/gsf-output-gio.c b/gsf/gsf-output-gio.c
index 4985664..6ffca0d 100644
--- a/gsf/gsf-output-gio.c
+++ b/gsf/gsf-output-gio.c
@@ -27,7 +27,6 @@
 
 struct _GsfOutputGio {
        GsfOutput output;
-       GFile *file;
        GOutputStream *stream;
        gboolean can_seek;
 };
@@ -63,7 +62,6 @@ gsf_output_gio_new_full (GFile *file, GError **err)
        }
 
        output = g_object_new (GSF_OUTPUT_GIO_TYPE, NULL);
-       output->file = g_object_ref (output->file);
        output->stream = stream;
        output->can_seek = can_seek (stream);
 
@@ -136,9 +134,6 @@ gsf_output_gio_close (GsfOutput *output)
                g_object_unref (gio->stream);
                gio->stream = NULL;
 
-               g_object_unref (gio->file);
-               gio->file = NULL;
-
                return TRUE;
        }
 
@@ -201,7 +196,6 @@ gsf_output_gio_init (GObject *obj)
 {
        GsfOutputGio *gio = GSF_OUTPUT_GIO (obj);
 
-       gio->file   = NULL;
        gio->stream = NULL;
        gio->can_seek = FALSE;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]