[gnome-software/wip/rancell/reviews] Coding style changes from review

[Robert Ancell <rancell src gnome org>]

commit 2dfeac3ed3ad27b0233cf7b4d7ac5aea32183cbe
Author: Robert Ancell <robert ancell canonical com>
Date:   Thu Feb 4 16:42:53 2016 +1300

    Coding style changes from review

 src/gs-app-review-row.c |   30 +++++++++++-------------------
 1 files changed, 11 insertions(+), 19 deletions(-)
---
diff --git a/src/gs-app-review-row.c b/src/gs-app-review-row.c
index a78c9ef..8804b02 100644
--- a/src/gs-app-review-row.c
+++ b/src/gs-app-review-row.c
@@ -45,24 +45,23 @@ gs_app_review_row_refresh (GsAppReviewRow *row)
 {
        const gchar *reviewer;
        GDateTime *date;
-       gchar *text;
+       g_autofree gchar *text;
 
        gs_star_widget_set_rating (GS_STAR_WIDGET (row->stars), gs_app_review_get_rating (row->review));
        reviewer = gs_app_review_get_reviewer (row->review);
        date = gs_app_review_get_date (row->review);
-       if (reviewer && date) {
+       if (reviewer != NULL && date != NULL) {
                gchar *date_text = g_date_time_format (date, "%e %B %Y");
                text = g_strdup_printf ("%s, %s", reviewer, date_text);
                g_free (date_text);
        }
-       else if (reviewer)
+       else if (reviewer != NULL)
                text = g_strdup (reviewer);
-       else if (date)
+       else if (date != NULL)
                text = g_date_time_format (date, "%e %B %Y");
        else
                text = g_strdup ("");
        gtk_label_set_text (GTK_LABEL (row->author_label), text);
-       g_free (text);
        gtk_label_set_text (GTK_LABEL (row->summary_label), gs_app_review_get_summary (row->review));
        gtk_label_set_text (GTK_LABEL (row->text_label), gs_app_review_get_text (row->review));
 }
@@ -87,17 +86,6 @@ gs_app_review_row_notify_props_changed_cb (GsApp *app,
 }
 
 static void
-gs_app_review_row_set_review (GsAppReviewRow *row, GsAppReview *review)
-{
-       row->review = g_object_ref (review);
-
-       g_signal_connect_object (row->review, "notify::state",
-                                G_CALLBACK (gs_app_review_row_notify_props_changed_cb),
-                                row, 0);
-       gs_app_review_row_refresh (row);
-}
-
-static void
 gs_app_review_row_init (GsAppReviewRow *row)
 {
        gtk_widget_set_has_window (GTK_WIDGET (row), FALSE);
@@ -141,14 +129,18 @@ gs_app_review_row_class_init (GsAppReviewRowClass *klass)
 GtkWidget *
 gs_app_review_row_new (GsAppReview *review)
 {
-       GtkWidget *row;
+       GsAppReviewRow *row;
 
        g_return_val_if_fail (GS_IS_APP_REVIEW (review), NULL);
 
        row = g_object_new (GS_TYPE_APP_REVIEW_ROW, NULL);
-       gs_app_review_row_set_review (GS_APP_REVIEW_ROW (row), review);
+       row->review = g_object_ref (review);
+       g_signal_connect_object (row->review, "notify::state",
+                                G_CALLBACK (gs_app_review_row_notify_props_changed_cb),
+                                row, 0);
+       gs_app_review_row_refresh (row);
 
-       return row;
+       return GTK_WIDGET (row);
 }
 
 /* vim: set noexpandtab: */