[bijiben] bjb-app-menu: use logo-icon-name to add an icon to about dialog



commit 2544124aadb75be3b16c79e15b0fb9b51a19251c
Author: Cosimo Cecchi <cosimoc gnome org>
Date:   Mon Feb 1 15:03:51 2016 -0800

    bjb-app-menu: use logo-icon-name to add an icon to about dialog
    
    This was previously displayed because we were calling
    gtk_window_set_icon_list(), but that was wrong as it will hardcode a
    specific resolution to the icon.
    The correct way to do this is to just use the "logo-icon-name" property
    of GtkAboutDialog.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=761436

 src/bjb-app-menu.c |   28 ++++++++++++++--------------
 src/bjb-app-menu.h |    3 ---
 2 files changed, 14 insertions(+), 17 deletions(-)
---
diff --git a/src/bjb-app-menu.c b/src/bjb-app-menu.c
index a088b37..7e4ed82 100644
--- a/src/bjb-app-menu.c
+++ b/src/bjb-app-menu.c
@@ -26,8 +26,8 @@
 #include "bjb-window-base.h"
 
 /* Callbacks */
-
-void show_about_dialog(GtkApplication *app)
+static void
+show_about_dialog (GtkApplication *app)
 {
   GList * windows = gtk_application_get_windows (app);
 
@@ -41,18 +41,18 @@ void show_about_dialog(GtkApplication *app)
     NULL
   };
 
-  gtk_show_about_dialog( g_list_nth_data (windows, 0),
-  "program-name", _("Notes"),
-  "comments", _("Simple notebook for GNOME"),
-  "license-type", GTK_LICENSE_GPL_3_0,
-  "version", VERSION,
-  "copyright", "Copyright © 2013 Pierre-Yves Luyten",
-  "authors", authors,
-  "artists", artists,
-  "translator-credits", _("translator-credits"),
-  "website", "https://wiki.gnome.org/Apps/Bijiben";,
-  NULL,NULL,NULL);
-
+  gtk_show_about_dialog (g_list_nth_data (windows, 0),
+                         "program-name", _("Notes"),
+                         "comments", _("Simple notebook for GNOME"),
+                         "license-type", GTK_LICENSE_GPL_3_0,
+                         "version", VERSION,
+                         "copyright", "Copyright © 2013 Pierre-Yves Luyten",
+                         "authors", authors,
+                         "artists", artists,
+                         "translator-credits", _("translator-credits"),
+                         "website", "https://wiki.gnome.org/Apps/Bijiben";,
+                         "logo-icon-name", "org.gnome.bijiben",
+                         NULL);
 }
 
 
diff --git a/src/bjb-app-menu.h b/src/bjb-app-menu.h
index ed6ce02..baf3d80 100644
--- a/src/bjb-app-menu.h
+++ b/src/bjb-app-menu.h
@@ -20,9 +20,6 @@
 
 #include <gtk/gtk.h>
 
-void          show_about_dialog            (GtkApplication *app);
-
-
 void          bjb_app_menu_set             (GApplication *application) ;
 
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]