[gtk+] Avoid a possible crash in ::activate-url handlers
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] Avoid a possible crash in ::activate-url handlers
- Date: Thu, 29 Dec 2016 16:09:30 +0000 (UTC)
commit 7e6820415d407eb4cd806595e97bec1664042322
Author: Matthias Clasen <mclasen redhat com>
Date: Thu Dec 29 11:07:05 2016 -0500
Avoid a possible crash in ::activate-url handlers
If the signal handler ends up changing the label text,
the link is no longer around to update the css node.
Check for this possibility to avoid a crash here.
gtk/gtklabel.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtklabel.c b/gtk/gtklabel.c
index 9b759be..10e69f4 100644
--- a/gtk/gtklabel.c
+++ b/gtk/gtklabel.c
@@ -6611,7 +6611,8 @@ emit_activate_link (GtkLabel *label,
GtkStateFlags state;
g_signal_emit (label, signals[ACTIVATE_LINK], 0, link->uri, &handled);
- if (handled && priv->track_links && !link->visited)
+ if (handled && priv->track_links && !link->visited &&
+ priv->select_info && priv->select_info->links)
{
link->visited = TRUE;
state = gtk_css_node_get_state (link->cssnode);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]