[pygobject] Move pep8/pyflakes tests from 'make check' to 'make check.quality'
- From: Christoph Reiter <creiter src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [pygobject] Move pep8/pyflakes tests from 'make check' to 'make check.quality'
- Date: Fri, 23 Dec 2016 09:09:41 +0000 (UTC)
commit 3f68e0a352abc12e1990e82e3134c48f0be2b3c9
Author: Christoph Reiter <creiter src gnome org>
Date: Wed Mar 23 17:07:53 2016 +0100
Move pep8/pyflakes tests from 'make check' to 'make check.quality'
The current behaviour is problematic because new versions of pep8/pyflakes
add new warnings or get more picky. This makes testing
hard in case newly added code is developed on an older version
or when testing old branches/releases.
This moves the pep8/pyflakes tests to a new "make check.quality"
command.
This also removes the SKIP_PEP8 flag which was added in 25d12afd06863ce
to speed up make check.
https://bugzilla.gnome.org/show_bug.cgi?id=764087
HACKING | 2 +-
Makefile.am | 12 +++++-------
2 files changed, 6 insertions(+), 8 deletions(-)
---
diff --git a/HACKING b/HACKING
index acb9d26..4d96e9a 100644
--- a/HACKING
+++ b/HACKING
@@ -34,4 +34,4 @@ Tests
'make check TEST_NAMES="test_gi.TestUtf8.test_utf8_full_return"' executes the
test_gi.TestUtf8.test_utf8_full_return test
'make check.gdb' executes all the tests in a gdb session
'make check.valgrind' executes all the tests in valgrind
-
+'make check.quality' executes pyflakes and pep8 tests
diff --git a/Makefile.am b/Makefile.am
index 186cfd7..6171e18 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -176,18 +176,16 @@ dist-hook: $(BUILT_EXTRA_DIST)
# pycheck_subdirs =
-check-local:
+check.quality:
@echo " CHECK Pyflakes" $(pycheck_dirs)
@if type pyflakes >/dev/null 2>&1; then \
(cd $(abs_top_srcdir) && pyflakes $(pycheck_dirs) ); \
else echo "skipped, pyflakes not installed"; \
fi
- @if test -z "$$SKIP_PEP8"; then \
- echo " CHECK PEP8"; \
- if type pep8 >/dev/null 2>&1; then \
- (cd $(abs_top_srcdir) && pep8 --ignore=E501,E123,E124,E402,E731 --repeat
--show-source $(pycheck_dirs) ); \
- else echo "skipped, pep8 not installed"; \
- fi; \
+ @echo " CHECK PEP8";
+ @if type pep8 >/dev/null 2>&1; then \
+ (cd $(abs_top_srcdir) && pep8 --ignore=E501,E123,E124,E402,E731 --repeat --show-source
$(pycheck_dirs) ); \
+ else echo "skipped, pep8 not installed"; \
fi
check.gdb:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]