[gnome-builder] makecache: Don't use a possibly NULL pointer



commit 1518f6d082fe92548496d47aa7a71ecab2f11005
Author: Matthew Leeds <mleeds redhat com>
Date:   Mon Dec 19 21:45:20 2016 -0600

    makecache: Don't use a possibly NULL pointer
    
    In ide_makecache_new_worker, self->runtime hasn't necessarily been set
    yet, so we should use the task_data pointer instead.

 plugins/autotools/ide-makecache.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/plugins/autotools/ide-makecache.c b/plugins/autotools/ide-makecache.c
index eaaa872..b836714 100644
--- a/plugins/autotools/ide-makecache.c
+++ b/plugins/autotools/ide-makecache.c
@@ -462,7 +462,7 @@ ide_makecache_new_worker (GTask        *task,
    * If the runtime has a "gmake" instead of "make", we want to prefer that
    * since we know it is GNU make.
    */
-  if (ide_runtime_contains_program_in_path (self->runtime, "gmake", cancellable))
+  if (ide_runtime_contains_program_in_path (runtime, "gmake", cancellable))
     self->make_name = "gmake";
 
   context = ide_object_get_context (IDE_OBJECT (self));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]