[evolution] Fix a use-after-free after editor's WebKitWebProcess crash
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution] Fix a use-after-free after editor's WebKitWebProcess crash
- Date: Wed, 14 Dec 2016 15:42:07 +0000 (UTC)
commit 7ebe6595d6f4c971b24af4a7f3b19d3c805e4f5a
Author: Milan Crha <mcrha redhat com>
Date: Wed Dec 14 16:20:45 2016 +0100
Fix a use-after-free after editor's WebKitWebProcess crash
When the HTML editor's WebProcess crashed, the callbacks to listen
for D-Bus' web extension signals had been still connected, even after
the webkit editor had been properly freed, which caused the use-after-free.
The signal handlers are properly unsubscribed in the dispose method of
the webkit editor, even after the WebProcess crash.
src/modules/webkit-editor/e-webkit-editor.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/src/modules/webkit-editor/e-webkit-editor.c b/src/modules/webkit-editor/e-webkit-editor.c
index b4ba5fd..67ac49f 100644
--- a/src/modules/webkit-editor/e-webkit-editor.c
+++ b/src/modules/webkit-editor/e-webkit-editor.c
@@ -5761,11 +5761,6 @@ webkit_editor_web_process_crashed_cb (EWebKitEditor *wk_editor)
g_warning (
"WebKitWebProcess (page id %ld) for EWebKitEditor crashed",
webkit_web_view_get_page_id (WEBKIT_WEB_VIEW (wk_editor)));
-
- wk_editor->priv->web_extension_selection_changed_cb_id = 0;
- wk_editor->priv->web_extension_content_changed_cb_id = 0;
- wk_editor->priv->web_extension_undo_redo_state_changed_cb_id = 0;
- wk_editor->priv->web_extension_user_changed_default_colors_cb_id = 0;
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]