[gjs/wip/ptomato/tests: 2/3] test locale: Delete commented-out test



commit 9889b38d2516e9d9ba92ffdcbc4e41c409718f01
Author: Philip Chimento <philip chimento gmail com>
Date:   Thu Dec 8 22:27:53 2016 -0800

    test locale: Delete commented-out test
    
    This was supposed to have been commented out temporarily, but I'm not
    aware of a way in which to create an invalid JSString that can't be
    converted to UTF-8, at least not from Javascript. Probably the '\ud800'
    triggered a bug in an earlier version of SpiderMonkey, but I don't think
    this test can sensibly pass anymore.

 installed-tests/js/testLocale.js |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
---
diff --git a/installed-tests/js/testLocale.js b/installed-tests/js/testLocale.js
index e50d0c2..987786b 100644
--- a/installed-tests/js/testLocale.js
+++ b/installed-tests/js/testLocale.js
@@ -32,10 +32,6 @@ function testToLocaleCompare() {
     JSUnit.assertTrue("a".localeCompare("b") < 0);
     JSUnit.assertEquals( 0, "a".localeCompare("a"));
     JSUnit.assertTrue("b".localeCompare("a") > 0);
-
-    // Again test error handling when conversion fails
-    //assertRaises(function() { "\ud800".localeCompare("a"); });
-    //assertRaises(function() { "a".localeCompare("\ud800"); });
 }
 
 JSUnit.gjstestRun(this, JSUnit.setUp, JSUnit.tearDown);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]