[empathy] accounts-dialog: Add various missing UI spacing

[Daniel Boles <dboles src gnome org>]

commit 5ad66def030024d3bb826916fa9a1a3d10fb02dc
Author: Daniel Boles <dboles src gnome org>
Date:   Thu Dec 1 00:47:15 2016 +0000

    accounts-dialog: Add various missing UI spacing
    
     * 12 px border around content stops action area's buttons hitting frame
     * 12 px border around details does the same for the Edit button there
     * 18 px margin for better separation between details and action area
     * Remove a no-op VBox
    
    My guess is the whole thing needs a redesign, but for now, this is a
    freebie that I think makes it look considerably less clumsy than before.

 src/empathy-accounts-dialog.c  |    4 +-
 src/empathy-accounts-dialog.ui |   50 +++++++++++++++------------------------
 2 files changed, 21 insertions(+), 33 deletions(-)
---
diff --git a/src/empathy-accounts-dialog.c b/src/empathy-accounts-dialog.c
index 21b3fd6..feaab2e 100644
--- a/src/empathy-accounts-dialog.c
+++ b/src/empathy-accounts-dialog.c
@@ -2399,10 +2399,9 @@ accounts_dialog_build_ui (EmpathyAccountsDialog *dialog)
   /* Tweak the dialog */
   gtk_window_set_title (GTK_WINDOW (dialog), _("Messaging and VoIP Accounts"));
   gtk_window_set_role (GTK_WINDOW (dialog), "accounts");
-
   gtk_window_set_default_size (GTK_WINDOW (dialog), 640, 450);
-
   gtk_window_set_type_hint (GTK_WINDOW (dialog), GDK_WINDOW_TYPE_HINT_DIALOG);
+  gtk_container_set_border_width (GTK_CONTAINER (dialog), 12);
 
   /* join the add/remove toolbar to the treeview */
   context = gtk_widget_get_style_context (sw);
@@ -2412,6 +2411,7 @@ accounts_dialog_build_ui (EmpathyAccountsDialog *dialog)
   gtk_style_context_set_junction_sides (context, GTK_JUNCTION_TOP);
 
   /* add dialog buttons */
+  gtk_widget_set_margin_top (action_area, 18);
   gtk_button_box_set_layout (GTK_BUTTON_BOX (action_area), GTK_BUTTONBOX_END);
 
   gtk_dialog_add_buttons (GTK_DIALOG (dialog),
diff --git a/src/empathy-accounts-dialog.ui b/src/empathy-accounts-dialog.ui
index 777187b..674bd80 100644
--- a/src/empathy-accounts-dialog.ui
+++ b/src/empathy-accounts-dialog.ui
@@ -4,7 +4,6 @@
   <!-- interface-naming-policy toplevel-contextual -->
   <object class="GtkHBox" id="accounts_dialog_hbox">
     <property name="visible">True</property>
-    <property name="border_width">6</property>
     <property name="spacing">18</property>
     <child>
       <object class="GtkVBox" id="vbox195">
@@ -108,46 +107,35 @@
         <property name="can_focus">True</property>
         <property name="show_tabs">False</property>
         <child>
-          <object class="GtkVBox" id="vbox214">
+          <object class="GtkVBox" id="vbox_details">
             <property name="visible">True</property>
-            <property name="spacing">18</property>
+            <property name="can_focus">False</property>
+            <child>
+              <placeholder/>
+            </child>
             <child>
-              <object class="GtkVBox" id="vbox_details">
+              <object class="GtkAlignment" id="alignment_infobar">
                 <property name="visible">True</property>
-                <property name="can_focus">False</property>
-                <property name="spacing">6</property>
                 <child>
                   <placeholder/>
                 </child>
+              </object>
+              <packing>
+                <property name="expand">False</property>
+                <property name="position">1</property>
+              </packing>
+            </child>
+            <child>
+              <object class="GtkAlignment" id="alignment_settings">
+                <property name="visible">True</property>
+                <property name="can_focus">False</property>
+                <property name="margin">12</property>
                 <child>
-                  <object class="GtkAlignment" id="alignment_infobar">
-                    <property name="visible">True</property>
-                    <child>
-                      <placeholder/>
-                    </child>
-                  </object>
-                  <packing>
-                    <property name="expand">False</property>
-                    <property name="position">1</property>
-                  </packing>
-                </child>
-                <child>
-                  <object class="GtkAlignment" id="alignment_settings">
-                    <property name="visible">True</property>
-                    <property name="can_focus">False</property>
-                    <property name="left_padding">6</property>
-                    <property name="right_padding">6</property>
-                    <child>
-                      <placeholder/>
-                    </child>
-                  </object>
-                  <packing>
-                    <property name="position">2</property>
-                  </packing>
+                  <placeholder/>
                 </child>
               </object>
               <packing>
-                <property name="position">1</property>
+                <property name="position">2</property>
               </packing>
             </child>
           </object>