[gnome-dictionary] gdict: Use appropriate sizing for DB chooser
- From: Emmanuele Bassi <ebassi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-dictionary] gdict: Use appropriate sizing for DB chooser
- Date: Wed, 31 Aug 2016 16:16:01 +0000 (UTC)
commit 0869d023a97e5070125f71cad71a41e5406978f1
Author: Emmanuele Bassi <ebassi gnome org>
Date: Wed Aug 31 16:49:46 2016 +0100
gdict: Use appropriate sizing for DB chooser
Forcing minimum sizes won't work on large scrolled content; we should be
using the min and max content height properties of the scrolled window,
and let the popover size itself within those constraints.
libgdict/gdict-database-chooser-button.c | 3 ---
libgdict/gdict-database-chooser.c | 5 +++--
2 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/libgdict/gdict-database-chooser-button.c b/libgdict/gdict-database-chooser-button.c
index badb3c1..221e0b6 100644
--- a/libgdict/gdict-database-chooser-button.c
+++ b/libgdict/gdict-database-chooser-button.c
@@ -274,9 +274,6 @@ lookup_end_cb (GdictContext *context,
gtk_spinner_stop (GTK_SPINNER (priv->spinner));
gtk_stack_set_visible_child_name (GTK_STACK (priv->stack), "chooser");
- gtk_widget_set_size_request (GTK_WIDGET (priv->popover), 300, -1);
- gtk_widget_set_vexpand (GTK_WIDGET (priv->popover), TRUE);
-
priv->is_loaded = TRUE;
}
diff --git a/libgdict/gdict-database-chooser.c b/libgdict/gdict-database-chooser.c
index d1cc1cb..616384c 100644
--- a/libgdict/gdict-database-chooser.c
+++ b/libgdict/gdict-database-chooser.c
@@ -333,8 +333,9 @@ gdict_database_chooser_constructor (GType type,
gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (sw),
GTK_POLICY_AUTOMATIC,
GTK_POLICY_AUTOMATIC);
- gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (sw),
- GTK_SHADOW_IN);
+ gtk_scrolled_window_set_shadow_type (GTK_SCROLLED_WINDOW (sw), GTK_SHADOW_IN);
+ gtk_scrolled_window_set_min_content_height (GTK_SCROLLED_WINDOW (sw), 200);
+ gtk_scrolled_window_set_max_content_height (GTK_SCROLLED_WINDOW (sw), 400);
gtk_box_pack_start (GTK_BOX (chooser), sw, TRUE, TRUE, 0);
gtk_widget_show (sw);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]