[gnome-software] Remove an app from the installed view when it's uninstalled

[Richard Hughes <rhughes src gnome org>]

commit 9e6fcac45ce1cc0c5ffc100797bb6c49174160d3
Author: Joaquim Rocha <jrocha endlessm com>
Date:   Fri Aug 26 23:06:36 2016 +0200

    Remove an app from the installed view when it's uninstalled
    
    If an app is uninstalled from outside the installed view (i.e. in the
    app's details view), then it would not be removed from the list of
    installed applications. Moreover, the app row's button would change to
    "Install" but clicking it would just try to remove the app again.
    
    These changes hide the app row from the installed view if its state has
    changed and it is now available or unknown (because we still want to
    show it there when it is installing).
    
    Signed-off-by: Richard Hughes <richard hughsie com>

 src/gs-shell-installed.c |   19 ++++++++++++++++---
 1 files changed, 16 insertions(+), 3 deletions(-)
---
diff --git a/src/gs-shell-installed.c b/src/gs-shell-installed.c
index 2736ef4..80d99a6 100644
--- a/src/gs-shell-installed.c
+++ b/src/gs-shell-installed.c
@@ -98,6 +98,14 @@ row_unrevealed (GObject *row, GParamSpec *pspec, gpointer data)
 }
 
 static void
+gs_shell_installed_unreveal_row (GsAppRow *app_row)
+{
+       gs_app_row_unreveal (app_row);
+       g_signal_connect (app_row, "unrevealed",
+                         G_CALLBACK (row_unrevealed), NULL);
+}
+
+static void
 gs_shell_installed_app_removed (GsPage *page, GsApp *app)
 {
        GsShellInstalled *self = GS_SHELL_INSTALLED (page);
@@ -108,9 +116,7 @@ gs_shell_installed_app_removed (GsPage *page, GsApp *app)
        for (l = children; l; l = l->next) {
                GsAppRow *app_row = GS_APP_ROW (l->data);
                if (gs_app_row_get_app (app_row) == app) {
-                       gs_app_row_unreveal (app_row);
-                       g_signal_connect (app_row, "unrevealed",
-                                         G_CALLBACK (row_unrevealed), NULL);
+                       gs_shell_installed_unreveal_row (app_row);
                }
        }
 }
@@ -129,9 +135,16 @@ static gboolean
 gs_shell_installed_invalidate_sort_idle (gpointer user_data)
 {
        GsAppRow *app_row = user_data;
+       GsApp *app = gs_app_row_get_app (app_row);
+       AsAppState state = gs_app_get_state (app);
 
        gtk_list_box_row_changed (GTK_LIST_BOX_ROW (app_row));
 
+       /* if the app has been uninstalled (which can happen from another view)
+        * we should removed it from the installed view */
+       if (state == AS_APP_STATE_AVAILABLE || state == AS_APP_STATE_UNKNOWN)
+               gs_shell_installed_unreveal_row (app_row);
+
        g_object_unref (app_row);
        return G_SOURCE_REMOVE;
 }