[gnome-packagekit] trivial: Use AX_APPEND_COMPILE_FLAGS directly



commit 2d8a56df774a8bbcd507581249cc274fc6453b70
Author: Richard Hughes <richard hughsie com>
Date:   Thu Aug 25 11:40:46 2016 +0100

    trivial: Use AX_APPEND_COMPILE_FLAGS directly
    
    This gives us more control over what warnings get enabled.

 configure.ac            |   52 +++++++++++++++++++++++++++++++++-------------
 src/gpk-enum.c          |    2 -
 src/gpk-update-viewer.c |    2 -
 3 files changed, 37 insertions(+), 19 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index 39d3355..885e8e6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -21,28 +21,50 @@ GTK_DOC_CHECK(1.9)
 AC_PATH_PROG(GLIB_GENMARSHAL, glib-genmarshal)
 
 WARN_CFLAGS_EXTRA="
-       -Wmissing-declarations
+       -Waggregate-return
+       -Warray-bounds
        -Wcast-align
-       -Wwrite-strings
-       -Wreturn-type
-       -Wformat-nonliteral
-       -Wmissing-format-attribute
        -Wclobbered
+       -Wdeclaration-after-statement
        -Wempty-body
+       -Wextra
+       -Wformat=2
+       -Wformat-nonliteral
+       -Wformat-security
+       -Wformat-signedness
        -Wignored-qualifiers
-       -Wsign-compare
-       -Wtype-limits
-       -Wuninitialized
-       -Waggregate-return
-       -Wdeclaration-after-statement
-       -Wshadow
-       -Wno-strict-aliasing
+       -Wimplicit-function-declaration
+       -Winit-self
        -Winline
+       -Wmissing-declarations
+       -Wmissing-format-attribute
+       -Wmissing-include-dirs
+       -Wmissing-noreturn
        -Wmissing-parameter-type
-       -Woverride-init
+       -Wmissing-prototypes
+       -Wnested-externs
        -Wno-discarded-qualifiers
-       -Wformat-signedness"
-AX_COMPILER_FLAGS([WARN_CFLAGS],[WARN_LDFLAGS], [yes], [$WARN_CFLAGS_EXTRA])
+       -Wno-missing-field-initializers
+       -Wno-strict-aliasing
+       -Wno-suggest-attribute=format
+       -Wno-unused-parameter
+       -Wold-style-definition
+       -Woverride-init
+       -Wpacked
+       -Wpointer-arith
+       -Wredundant-decls
+       -Wreturn-type
+       -Wshadow
+       -Wsign-compare
+       -Wstrict-aliasing
+       -Wstrict-prototypes
+       -Wswitch-default
+       -Wtype-limits
+       -Wundef
+       -Wuninitialized
+       -Wunused-but-set-variable
+       -Wwrite-strings"
+AX_APPEND_COMPILE_FLAGS([$WARN_CFLAGS_EXTRA], [WARN_CFLAGS])
 
 dnl ---------------------------------------------------------------------------
 dnl - xsltproc
diff --git a/src/gpk-enum.c b/src/gpk-enum.c
index 9067f01..4f15fae 100644
--- a/src/gpk-enum.c
+++ b/src/gpk-enum.c
@@ -21,8 +21,6 @@
 
 #include "config.h"
 
-#pragma GCC diagnostic ignored "-Wswitch-enum"
-
 #include <glib.h>
 #include <glib/gi18n.h>
 #include <packagekit-glib2/packagekit.h>
diff --git a/src/gpk-update-viewer.c b/src/gpk-update-viewer.c
index 26d7ad2..b274401 100644
--- a/src/gpk-update-viewer.c
+++ b/src/gpk-update-viewer.c
@@ -21,8 +21,6 @@
 
 #include "config.h"
 
-#pragma GCC diagnostic ignored "-Wswitch-enum"
-
 #include <gdk/gdkkeysyms.h>
 #include <glib/gi18n.h>
 #include <glib/gi18n.h>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]