[evolution] Fix a memory leak of an old setting value from test_utils_fixture_change_setting()
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution] Fix a memory leak of an old setting value from test_utils_fixture_change_setting()
- Date: Wed, 24 Aug 2016 06:16:59 +0000 (UTC)
commit 601ee0bc8fdf88beb4dd6c9978b9535f2278bdd9
Author: Milan Crha <mcrha redhat com>
Date: Wed Aug 24 08:15:05 2016 +0200
Fix a memory leak of an old setting value from test_utils_fixture_change_setting()
It seems the g_settings_get_value() returns already sunk reference
on the GVariant, thus the g_variant_ref_sink() added a new hard
reference on it, instead of sink it.
e-util/test-html-editor-units-utils.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/e-util/test-html-editor-units-utils.c b/e-util/test-html-editor-units-utils.c
index 9e1ee52..8319941 100644
--- a/e-util/test-html-editor-units-utils.c
+++ b/e-util/test-html-editor-units-utils.c
@@ -274,7 +274,7 @@ test_utils_fixture_change_setting (TestFixture *fixture,
data = g_new0 (TestSettings, 1);
data->schema = g_strdup (schema);
data->key = g_strdup (key);
- data->old_value = g_variant_ref_sink (g_settings_get_value (settings, key));
+ data->old_value = g_settings_get_value (settings, key);
/* Use prepend, thus the restore comes in the opposite order, thus a change
of the same key is not a problem. */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]