[gnome-builder/wip/chergert/sysprof: 10/18] subprocess: add note about future cleanup



commit b0bab83515a98e60df878653acce855213d19818
Author: Christian Hergert <chergert redhat com>
Date:   Mon Aug 22 18:36:31 2016 -0700

    subprocess: add note about future cleanup

 libide/workers/ide-subprocess-launcher.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
---
diff --git a/libide/workers/ide-subprocess-launcher.c b/libide/workers/ide-subprocess-launcher.c
index ba37a9d..44e6563 100644
--- a/libide/workers/ide-subprocess-launcher.c
+++ b/libide/workers/ide-subprocess-launcher.c
@@ -180,6 +180,11 @@ ide_subprocess_launcher_real_spawn_async (IdeSubprocessLauncher *self,
   g_assert (IDE_IS_SUBPROCESS_LAUNCHER (self));
   g_assert (!cancellable || G_IS_CANCELLABLE (cancellable));
 
+  /*
+   * TODO: Adding threads here doesn't really make things any easier.
+   *       We should just spawn synchronously in the current thread.
+   */
+
   task = g_task_new (self, cancellable, callback, user_data);
   g_task_run_in_thread (task, ide_subprocess_launcher_spawn_worker);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]