[gnome-music] view: Factor out function to setup the view
- From: Marinus Schraal <mschraal src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-music] view: Factor out function to setup the view
- Date: Mon, 22 Aug 2016 14:38:09 +0000 (UTC)
commit 5071f941e8c738f01aea10fff578110927197340
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Tue Aug 9 01:31:11 2016 -0300
view: Factor out function to setup the view
Groundwork for GtkFlowBox Albums view introduction.
Since the Albums view will handle the internal view differently, it
makes sense to add a new method that will be overriden in the future.
This patch moves the code related to setting up the view into a separate
function.
https://bugzilla.gnome.org/show_bug.cgi?id=760164
gnomemusic/view.py | 19 ++++++++++++-------
1 files changed, 12 insertions(+), 7 deletions(-)
---
diff --git a/gnomemusic/view.py b/gnomemusic/view.py
index 741a28d..38cc975 100644
--- a/gnomemusic/view.py
+++ b/gnomemusic/view.py
@@ -89,10 +89,10 @@ class ViewContainer(Gtk.Stack):
GObject.TYPE_BOOLEAN,
GObject.TYPE_INT
)
- self.view = Gd.MainView(
- shadow_type=Gtk.ShadowType.NONE
- )
- self.view.set_view_type(view_type)
+
+ # Setup the main view
+ self._setup_view(view_type)
+
self._box = Gtk.Box(orientation=Gtk.Orientation.VERTICAL)
self._box.pack_start(self.view, True, True, 0)
if use_sidebar:
@@ -111,9 +111,6 @@ class ViewContainer(Gtk.Stack):
self._grid.add(self._box)
self.star_handler = Widgets.StarHandler(self, 9)
- self.view.click_handler = self.view.connect('item-activated', self._on_item_activated)
- # self.star_handler.star_renderer_click = False
- self.view.connect('selection-mode-request', self._on_selection_mode_request)
self._cursor = None
self.window = window
self.header_bar = window.toolbar
@@ -149,6 +146,14 @@ class ViewContainer(Gtk.Stack):
pass
@log
+ def _setup_view(self, view_type):
+ self.view = Gd.MainView(shadow_type=Gtk.ShadowType.NONE)
+ self.view.set_view_type(view_type)
+
+ self.view.click_handler = self.view.connect('item-activated', self._on_item_activated)
+ self.view.connect('selection-mode-request', self._on_selection_mode_request)
+
+ @log
def _on_header_bar_toggled(self, button):
if button.get_active():
self.view.set_selection_mode(True)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]