[cluttermm] Revert "Init: Uncomment the init() overload that takes an OptionContext."
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [cluttermm] Revert "Init: Uncomment the init() overload that takes an OptionContext."
- Date: Sat, 20 Aug 2016 22:29:03 +0000 (UTC)
commit b515ece618133cdde4a28ce1f13913116520c995
Author: Murray Cumming <murrayc murrayc com>
Date: Sun Aug 21 00:19:43 2016 +0200
Revert "Init: Uncomment the init() overload that takes an OptionContext."
This reverts commit 2e414ce7b4c94364bfae08755cca2ac63c92ff81.
clutter/cluttermm/init.cc | 13 +++++++------
clutter/cluttermm/init.h | 5 +++++
2 files changed, 12 insertions(+), 6 deletions(-)
---
diff --git a/clutter/cluttermm/init.cc b/clutter/cluttermm/init.cc
index a2044cc..ced68c8 100644
--- a/clutter/cluttermm/init.cc
+++ b/clutter/cluttermm/init.cc
@@ -53,6 +53,10 @@ void init(int& argc, gchar**& argv)
init(&argc, &argv);
}
+// TODO: This does not work yet because because of clutter bug #1033. It has
+// already been fixed in trunk but there was no release since. We can
+// uncomment this as soon as clutter with that fix has been released.
+#if 0
void init(int* argc, gchar** argv[], Glib::OptionContext& option_context)
{
common_init();
@@ -60,18 +64,15 @@ void init(int* argc, gchar** argv[], Glib::OptionContext& option_context)
add_clutter_option_group(option_context);
option_context.parse(*argc, *argv);
// option_context_parse already parsed the clutter arguments:
- const ClutterInitError result = clutter_init_with_args(NULL, NULL, NULL, NULL, NULL, &error);
- if(error)
- Glib::Error::throw_exception(error);
-
- if(result != CLUTTER_INIT_SUCCESS)
- throw Glib::Error(); //This should never happen. The GError should always be set.
+ clutter_init_with_args(NULL, NULL, NULL, NULL, NULL, &error);
+ if(error != NULL) Glib::Error::throw_exception(error);
}
void init(int& argc, gchar**& argv, Glib::OptionContext& option_context)
{
init(&argc, &argv, option_context);
}
+#endif
void add_clutter_option_group(Glib::OptionContext& option_context)
{
diff --git a/clutter/cluttermm/init.h b/clutter/cluttermm/init.h
index 8dee136..d81f50f 100644
--- a/clutter/cluttermm/init.h
+++ b/clutter/cluttermm/init.h
@@ -44,6 +44,10 @@ void init(int* argc, gchar** argv[]);
*/
void init(int& argc, gchar**& argv);
+// TODO: This does not work yet because because of clutter bug #1033. It has
+// already been fixed in trunk but there was no release since. We can
+// uncomment this as soon as clutter with that fix has been released.
+#if 0
/** It will initialise everything needed to operate with Clutter and parses
* some standard command line options and the options specified in your
* @a option_context. Add a Glib::OptionGroup to the Glib::OptionContext to
@@ -67,6 +71,7 @@ void init(int* argc, char** argv[], Glib::OptionContext& option_context);
* @throws InitError, Glib::OptionError
*/
void init(int& argc, char**& argv, Glib::OptionContext& option_context);
+#endif
/** Adds a Glib::OptionGroup for the command line arguments recognized by
* Clutter to the given context. This is useful if you are using
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]