[gnome-builder] git: avoid ::reloaded emission if the task failed



commit 8482066f1580f24660a0d53e16e3c4860cbd59d2
Author: Christian Hergert <chergert redhat com>
Date:   Wed Aug 17 15:36:36 2016 +0200

    git: avoid ::reloaded emission if the task failed

 plugins/git/ide-git-vcs.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/plugins/git/ide-git-vcs.c b/plugins/git/ide-git-vcs.c
index 7659d2e..02379cb 100644
--- a/plugins/git/ide-git-vcs.c
+++ b/plugins/git/ide-git-vcs.c
@@ -320,11 +320,14 @@ ide_git_vcs_reload_finish (IdeGitVcs     *self,
 
   self->reloading = FALSE;
 
-  g_signal_emit (self, signals [RELOADED], 0, self->change_monitor_repository);
-  ide_vcs_emit_changed (IDE_VCS (self));
-
   ret = g_task_propagate_boolean (task, error);
 
+  if (ret)
+    {
+      g_signal_emit (self, signals [RELOADED], 0, self->change_monitor_repository);
+      ide_vcs_emit_changed (IDE_VCS (self));
+    }
+
   IDE_RETURN (ret);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]