[polari/wip/fmuellner/misc-fixes: 18/20] roomList: Exclude placeholders from show_all()



commit 0b744cd9df7e5929de0fac3047cdc36b58ef64d9
Author: Florian Müllner <fmuellner gnome org>
Date:   Sun Aug 7 00:14:53 2016 +0200

    roomList: Exclude placeholders from show_all()
    
    For enabled accounts without rooms, we show an empty placeholder widget
    so that we still get the header that allows managing the account. While
    we correctly set the initial visibility, that code may run before any
    parent calls show_all(), and we end up with disabled accounts in the
    sidebar - we need to control the placeholders' visibility ourselves,
    so exclude them from show_all().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=769592

 src/roomList.js |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/src/roomList.js b/src/roomList.js
index 519b8c1..f67e575 100644
--- a/src/roomList.js
+++ b/src/roomList.js
@@ -496,7 +496,8 @@ const RoomList = new Lang.Class({
             return;
 
         let placeholder = new Gtk.ListBoxRow({ selectable: false,
-                                               activatable: false });
+                                               activatable: false,
+                                               no_show_all: true });
         placeholder.account = account;
 
         this._placeholders.set(account, placeholder);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]