[polari] app: Set 'use-ssl' when retrying with another server
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [polari] app: Set 'use-ssl' when retrying with another server
- Date: Thu, 4 Aug 2016 21:43:35 +0000 (UTC)
commit fac7220764b7b4feb246f08f3f4690fc249071c1
Author: Florian Müllner <fmuellner gnome org>
Date: Tue Aug 2 22:47:20 2016 +0200
app: Set 'use-ssl' when retrying with another server
When creating an account from a predefined network, we always use
SSL when available. Likewise, all servers return by the networks
manager will be SSL-enabled if the networks supports it. So in
theory, the 'use-ssl' parameter should already be correct and
we don't need to update it. However there have been reports
where the parameter got unset for some reason, with the result
that all connection attempts fail. While it would be interesting
to figure out how exactly the parameter is lost, setting it
anyway when retrying with another server is still a good idea,
as account could always have been modified externally.
https://bugzilla.gnome.org/show_bug.cgi?id=766935
src/application.js | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/src/application.js b/src/application.js
index 3d3ec7c..81975d6 100644
--- a/src/application.js
+++ b/src/application.js
@@ -352,7 +352,9 @@ const Application = new Lang.Class({
_updateAccountServer: function(account, server, callback) {
let sv = { server: GLib.Variant.new('s', server.address),
- port: GLib.Variant.new('u', server.port) };
+ port: GLib.Variant.new('u', server.port),
+ 'use-ssl': GLib.Variant.new('b', server.ssl)
+ };
let asv = GLib.Variant.new('a{sv}', sv);
account.update_parameters_vardict_async(asv, [], callback);
},
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]