[gnome-devel-docs] programming-guidelines: Fix instructions for VALGRIND_CHECK_RULES



commit 0c65695b022fc7ab08be3f625ae834aece381c34
Author: Philip Withnall <philip withnall collabora co uk>
Date:   Mon Aug 1 16:02:17 2016 +0100

    programming-guidelines: Fix instructions for VALGRIND_CHECK_RULES
    
    There was a missing ‘@’, and it erronously suggested to add it to the
    top-level Makefile.am, rather than the Makefile.am containing the tests
    you want to valgrind.
    
    Spotted by Sébastien Wilmet.

 programming-guidelines/C/tooling.page |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/programming-guidelines/C/tooling.page b/programming-guidelines/C/tooling.page
index 6e2c9c9..8938635 100644
--- a/programming-guidelines/C/tooling.page
+++ b/programming-guidelines/C/tooling.page
@@ -231,14 +231,15 @@ AX_COMPILER_FLAGS([WARN_CFLAGS],[WARN_LDFLAGS],[$ax_is_release])</code>
         Add <code>AX_VALGRIND_CHECK</code> to <file>configure.ac</file>.
       </p></item>
       <item><p>
-        Add <code>@VALGRIND_CHECK_RULES</code> to the top-level
-        <file>Makefile.am</file>.
+        Add <code>@VALGRIND_CHECK_RULES@</code> to the <file>Makefile.am</file>
+        in each directory which contains unit tests.
       </p></item>
     </steps>
 
     <p>
       When <cmd>make check-valgrind</cmd> is run, it will save its results in
-      <file>test-suite-*.log</file>, one log file per tool.
+      <file>test-suite-*.log</file>, one log file per tool. Note that you will
+      need to run it from the directory containing the unit tests.
     </p>
 
     <comment>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]