[network-manager-openvpn] import: port is not mandatory for socks proxy
- From: Lubomir Rintel <lkundrak src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [network-manager-openvpn] import: port is not mandatory for socks proxy
- Date: Thu, 28 Apr 2016 15:24:48 +0000 (UTC)
commit d87b09418a8f45356d290430f1f15655adedfd84
Author: Lubomir Rintel <lkundrak v3 sk>
Date: Thu Apr 28 17:21:35 2016 +0200
import: port is not mandatory for socks proxy
CID 99743 (#1 of 2): Logically dead code (DEADCODE)dead_error_line:
Execution cannot reach this statement: proxy_port = "1080";.
properties/import-export.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/properties/import-export.c b/properties/import-export.c
index a23d482..851a8ca 100644
--- a/properties/import-export.c
+++ b/properties/import-export.c
@@ -1866,7 +1866,7 @@ do_export_create (NMConnection *connection, const char *path, GError **error)
g_free (authcontents);
}
g_free (authfile);
- } else if (nm_streq (proxy_type, "socks") && proxy_server && proxy_port) {
+ } else if (nm_streq (proxy_type, "socks") && proxy_server) {
if (!proxy_port)
proxy_port = "1080";
args_write_line (f, NMV_OVPN_TAG_SOCKS_PROXY, proxy_server, proxy_port);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]