[pitivi] Clipproperties: Automaticaly open properites for video effect.



commit 05ba6c869adc1d23098d44930f6a89f4adb1c03a
Author: --global <maxime lacroix69110 gmail com>
Date:   Fri Mar 25 20:18:06 2016 +0100

    Clipproperties: Automaticaly open properites for video effect.
    
    When an effect is added to a clip now opens propreties to make it more intuitive for the user.
    
    Call to self.__updateAll() is not needed in addEffectToClip since we already get it done in
    the track-element-added callback.
    
    Fixes T7536
    
    Differential Revision: https://phabricator.freedesktop.org/D897

 pitivi/clipproperties.py    |    5 ++++-
 pitivi/timeline/elements.py |    5 +++--
 2 files changed, 7 insertions(+), 3 deletions(-)
---
diff --git a/pitivi/clipproperties.py b/pitivi/clipproperties.py
index 72cf05b..3457ac0 100644
--- a/pitivi/clipproperties.py
+++ b/pitivi/clipproperties.py
@@ -283,6 +283,10 @@ class EffectProperties(Gtk.Expander, Loggable):
             selec = self._selection.getSelectedEffects()
             self.selected_effects = selec
             self.__updateAll()
+            for path, row in enumerate(self.storemodel):
+                if row[COL_TRACK_EFFECT] == track_element:
+                    self.treeview_selection.select_path(path)
+                    break
 
     def _trackElementRemovedCb(self, unused_clip, track_element):
         if isinstance(track_element, GES.BaseEffect):
@@ -322,7 +326,6 @@ class EffectProperties(Gtk.Expander, Loggable):
                     if priority is not None and priority < len(model):
                         clip.set_top_effect_priority(effect, priority)
                     self._project.timeline.commit()
-                self.__updateAll()
                 break
 
     def addEffectToCurrentSelection(self, factory_name):
diff --git a/pitivi/timeline/elements.py b/pitivi/timeline/elements.py
index 08904f7..b786e64 100644
--- a/pitivi/timeline/elements.py
+++ b/pitivi/timeline/elements.py
@@ -762,11 +762,12 @@ class Clip(Gtk.EventBox, timelineUtils.Zoomable, Loggable):
 
         if target.name() == ui.EFFECT_TARGET_ENTRY.target:
             self.info("Adding effect %s", self.timeline.dropData)
-            self.app.gui.clipconfig.effect_expander.addEffectToClip(self.ges_clip,
-                                                                    self.timeline.dropData)
             self.timeline.resetSelectionGroup()
             self.timeline.selection.setSelection([self.ges_clip], timelineUtils.SELECT)
             self.app.gui.switchContextTab(self.ges_clip)
+
+            self.app.gui.clipconfig.effect_expander.addEffectToClip(self.ges_clip,
+                                                                    self.timeline.dropData)
             self.timeline.cleanDropData()
             success = True
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]