[gnome-boxes/gnome-3-20] wizard: Ignore unimportable VMs early

[Zeeshan Ali Khattak <zeeshanak src gnome org>]

commit d53c440e37e42fc031cb9c262446bf1fc746d3dc
Author: Visarion Alexandru <viorel visarion gmail com>
Date:   Mon Apr 11 10:40:08 2016 +0300

    wizard: Ignore unimportable VMs early
    
    We currently assume all system libvirt VMs to be importable and end up
    providing an option to import unimportable VMs and failing to import
    them when user chooses that option. This looks really bad.
    
    Let's check the existence of the VMs' disk images and ensure their
    readability, early on and simply ignore the VMs without a valid disk
    image attached to them.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=754500

 src/libvirt-system-importer.vala |   36 ++++++++++++++++++++++--------------
 1 files changed, 22 insertions(+), 14 deletions(-)
---
diff --git a/src/libvirt-system-importer.vala b/src/libvirt-system-importer.vala
index 80ad064..b273b47 100644
--- a/src/libvirt-system-importer.vala
+++ b/src/libvirt-system-importer.vala
@@ -8,7 +8,10 @@ errordomain Boxes.LibvirtSystemImporterError {
 
 private class Boxes.LibvirtSystemImporter: GLib.Object {
     private GVir.Connection connection;
+
     private GLib.List<GVir.Domain> domains;
+    private string[] disk_paths;
+    private GVirConfig.Domain[] configs;
 
     public string wizard_menu_label {
         owned get {
@@ -41,24 +44,23 @@ private class Boxes.LibvirtSystemImporter: GLib.Object {
     public async LibvirtSystemImporter () throws GLib.Error {
         connection = yield get_system_virt_connection ();
 
-        domains = system_virt_connection.get_domains ();
-        debug ("Fetched %u domains from system libvirt.", domains.length ());
-        if (domains.length () == 0)
-            throw new LibvirtSystemImporterError.NO_IMPORTS (_("No boxes to import"));
-    }
-
-    public async void import () {
-        GVirConfig.Domain[] configs = {};
-        string[] disk_paths = {};
+        var domains = system_virt_connection.get_domains ();
 
         foreach (var domain in domains) {
-            GVirConfig.Domain config;
-            string disk_path;
-
             try {
+                string disk_path;
+                var config = new GVirConfig.Domain ();
+
                 get_domain_info (domain, out config, out disk_path);
-                configs += config;
-                disk_paths += disk_path;
+
+                var file = File.new_for_path (disk_path);
+                if (file.query_exists ()) {
+                    this.domains.append (domain);
+                    disk_paths += disk_path;
+                    configs += config;
+                } else {
+                    debug ("Could not find a valid disk image for %s", domain.get_name ());
+                }
             } catch (GLib.Error error) {
                 warning ("%s", error.message);
             }
@@ -72,6 +74,12 @@ private class Boxes.LibvirtSystemImporter: GLib.Object {
             return;
         }
 
+        debug ("Fetched %u domains from system libvirt.", this.domains.length ());
+        if (this.domains.length () == 0)
+            throw new LibvirtSystemImporterError.NO_IMPORTS (_("No boxes to import"));
+    }
+
+    public async void import () {
         for (var i = 0; i < configs.length; i++)
             import_domain.begin (configs[i], disk_paths[i], null);
     }