[gnome-software] Fix the upgrade state transitions to actually work

[Richard Hughes <rhughes src gnome org>]

commit b2354c5156f2e5cffb175bbe074cfb132f9370a7
Author: Richard Hughes <richard hughsie com>
Date:   Tue Apr 12 18:42:52 2016 +0100

    Fix the upgrade state transitions to actually work

 src/gs-app.c           |    1 +
 src/gs-plugin-loader.c |    4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/gs-app.c b/src/gs-app.c
index 7315a4f..4743375 100644
--- a/src/gs-app.c
+++ b/src/gs-app.c
@@ -453,6 +453,7 @@ gs_app_set_state_internal (GsApp *app, AsAppState state)
                /* installing has to go into an stable state */
                if (state == AS_APP_STATE_UNKNOWN ||
                    state == AS_APP_STATE_INSTALLED ||
+                   state == AS_APP_STATE_UPDATABLE ||
                    state == AS_APP_STATE_AVAILABLE)
                        state_change_ok = TRUE;
                break;
diff --git a/src/gs-plugin-loader.c b/src/gs-plugin-loader.c
index 373c31e..e76757b 100644
--- a/src/gs-plugin-loader.c
+++ b/src/gs-plugin-loader.c
@@ -2730,8 +2730,8 @@ gs_plugin_loader_app_action_async (GsPluginLoader *plugin_loader,
                break;
        case GS_PLUGIN_LOADER_ACTION_UPGRADE_DOWNLOAD:
                state->function_name = "gs_plugin_app_upgrade_download";
-               state->state_success = AS_APP_STATE_AVAILABLE;
-               state->state_failure = AS_APP_STATE_UPDATABLE;
+               state->state_success = AS_APP_STATE_UPDATABLE;
+               state->state_failure = AS_APP_STATE_AVAILABLE;
                break;
        case GS_PLUGIN_LOADER_ACTION_UPGRADE_TRIGGER:
                state->function_name = "gs_plugin_app_upgrade_trigger";