[orca] Fix regression from keyboard event refactor
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Fix regression from keyboard event refactor
- Date: Tue, 5 Apr 2016 15:52:29 +0000 (UTC)
commit 9e5ed44c5c40d382a8063115d074bed12c3d46c3
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Tue Apr 5 11:51:49 2016 -0400
Fix regression from keyboard event refactor
src/orca/input_event.py | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
---
diff --git a/src/orca/input_event.py b/src/orca/input_event.py
index 83fd0c3..6307f5c 100644
--- a/src/orca/input_event.py
+++ b/src/orca/input_event.py
@@ -461,10 +461,11 @@ class KeyboardEvent(InputEvent):
return False, 'Capturing keys'
self._handler = self._script.keyBindings.getInputHandler(self)
- if self._handler:
- scriptConsumes = self._script.consumesKeyboardEvent(self)
- else:
- scriptConsumes = False
+
+ # TODO - JD: Right now we need to always call consumesKeyboardEvent()
+ # because that method is updating state, even in instances where there
+ # is no handler.
+ scriptConsumes = self._script.consumesKeyboardEvent(self)
if self.is_duplicate:
return scriptConsumes, 'Consuming based on handler'
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]