[gtksourceview/wip/public-region: 1/3] region: make it public



commit 0f4ef1260eb000d7222300c9f4f676a05ef779db
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sun Apr 3 16:49:41 2016 +0200

    region: make it public
    
    The implementation could be improved. I added a FIXME comment, and a
    GSequence would be a better data structure than a GList. But the region
    utility has served GtkSourceView well during 14 years. Instead of
    waiting that the code is perfect and waiting another 14 years, it's
    better to make the class public now. If someone wants to write a perfect
    code and wants to try to get it included in GTK+, at that point we can
    deprecate GtkSourceRegion. But I think GtkSourceRegion is now good
    enough to be public.

 gtksourceview/Makefile.am       |    4 ++--
 gtksourceview/gtksourceregion.h |   28 ++++++++++++++--------------
 2 files changed, 16 insertions(+), 16 deletions(-)
---
diff --git a/gtksourceview/Makefile.am b/gtksourceview/Makefile.am
index 40544fe..c6b0946 100644
--- a/gtksourceview/Makefile.am
+++ b/gtksourceview/Makefile.am
@@ -43,6 +43,7 @@ libgtksourceview_public_headers =             \
        gtksourcemark.h                         \
        gtksourcemarkattributes.h               \
        gtksourceprintcompositor.h              \
+       gtksourceregion.h                       \
        gtksourcesearchcontext.h                \
        gtksourcesearchsettings.h               \
        gtksourcestyle.h                        \
@@ -79,6 +80,7 @@ libgtksourceview_public_c_files =             \
        gtksourcemark.c                         \
        gtksourcemarkattributes.c               \
        gtksourceprintcompositor.c              \
+       gtksourceregion.c                       \
        gtksourcesearchcontext.c                \
        gtksourcesearchsettings.c               \
        gtksourcestyle.c                        \
@@ -112,7 +114,6 @@ libgtksourceview_private_headers =          \
        gtksourcemarkssequence.h                \
        gtksourcepixbufhelper.h                 \
        gtksourceregex.h                        \
-       gtksourceregion.h                       \
        gtksourcestyle-private.h                \
        gtksourcetypes-private.h                \
        gtksourceundomanagerdefault.h           \
@@ -134,7 +135,6 @@ libgtksourceview_private_c_files =  \
        gtksourcemarkssequence.c        \
        gtksourcepixbufhelper.c         \
        gtksourceregex.c                \
-       gtksourceregion.c               \
        gtksourceundomanagerdefault.c   \
        gtksourceview-i18n.c            \
        gtksourceview-utils.c
diff --git a/gtksourceview/gtksourceregion.h b/gtksourceview/gtksourceregion.h
index 7fc8316..ea42ad9 100644
--- a/gtksourceview/gtksourceregion.h
+++ b/gtksourceview/gtksourceregion.h
@@ -24,13 +24,13 @@
 #define __GTK_SOURCE_REGION_H__
 
 #include <gtk/gtk.h>
-#include "gtksourcetypes-private.h"
+#include <gtksourceview/gtksourceversion.h>
 
 G_BEGIN_DECLS
 
 #define GTK_SOURCE_TYPE_REGION (gtk_source_region_get_type ())
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 G_DECLARE_DERIVABLE_TYPE (GtkSourceRegion, gtk_source_region,
                          GTK_SOURCE, REGION,
                          GObject)
@@ -56,51 +56,51 @@ struct _GtkSourceRegionIter
        gpointer dummy3;
 };
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 GtkSourceRegion *      gtk_source_region_new                   (GtkTextBuffer *buffer);
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 GtkTextBuffer *                gtk_source_region_get_buffer            (GtkSourceRegion *region);
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 void                   gtk_source_region_add                   (GtkSourceRegion   *region,
                                                                 const GtkTextIter *_start,
                                                                 const GtkTextIter *_end);
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 void                   gtk_source_region_subtract              (GtkSourceRegion   *region,
                                                                 const GtkTextIter *_start,
                                                                 const GtkTextIter *_end);
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 GtkSourceRegion *      gtk_source_region_intersect             (GtkSourceRegion   *region,
                                                                 const GtkTextIter *_start,
                                                                 const GtkTextIter *_end);
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 gboolean               gtk_source_region_is_empty              (GtkSourceRegion *region);
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 gboolean               gtk_source_region_get_bounds            (GtkSourceRegion *region,
                                                                 GtkTextIter     *start,
                                                                 GtkTextIter     *end);
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 void                   gtk_source_region_get_start_region_iter (GtkSourceRegion     *region,
                                                                 GtkSourceRegionIter *iter);
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 gboolean               gtk_source_region_iter_is_end           (GtkSourceRegionIter *iter);
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 gboolean               gtk_source_region_iter_next             (GtkSourceRegionIter *iter);
 
-GTK_SOURCE_INTERNAL
+GTK_SOURCE_AVAILABLE_IN_3_22
 gboolean               gtk_source_region_iter_get_subregion    (GtkSourceRegionIter *iter,
                                                                 GtkTextIter         *start,
                                                                 GtkTextIter         *end);
 
-GTK_SOURCE_INTERNAL
+G_GNUC_INTERNAL
 void                   _gtk_source_region_debug_print          (GtkSourceRegion *region);
 
 G_END_DECLS


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]