[polari] connections: Always hide default port
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [polari] connections: Always hide default port
- Date: Fri, 1 Apr 2016 14:14:07 +0000 (UTC)
commit bbb6d2a1af301acd140fa3c9c1b42efda61edf69
Author: Florian Müllner <fmuellner gnome org>
Date: Fri Apr 1 13:34:20 2016 +0200
connections: Always hide default port
When filling the details dialog from an existing account, we do not
append the port to the server address if it matches the default port
for unencrypted connections - this makes sense as the information is
redundant and there's a good chance that the user did not actually
specify the port in the first place. However not doing the same for
encrypted connections means that the "secure connection" checkbox
unexpectedly affects the server entry as well: Without a specified
port, unchecking the box will append the default SSL port. Never
appending the respective default port is less likely to result in
confusing behavior, so do that instead.
src/connections.js | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/connections.js b/src/connections.js
index 512acfc..daa3120 100644
--- a/src/connections.js
+++ b/src/connections.js
@@ -294,7 +294,7 @@ const ConnectionDetails = new Lang.Class({
this._savedNick = params.account || '';
this._savedRealname = params.fullname || '';
- if (port != 6667)
+ if (port != defaultPort)
this._savedServer += ':%d'.format(port);
if (this._savedServer != account.display_name)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]