[polari] chatView: Factor out _getNickTagName() method



commit 05620bee98c5c89f710d8bdfd982d3430bf5b5b2
Author: Florian Müllner <fmuellner gnome org>
Date:   Thu Sep 17 14:28:30 2015 +0200

    chatView: Factor out _getNickTagName() method
    
    We need to generate a tag name from a nick both when creating the tag
    and when looking it up. Add a small method for that to make sure to
    use the same tag name in either place.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=755133

 src/chatView.js |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)
---
diff --git a/src/chatView.js b/src/chatView.js
index d6979c1..6fb624a 100644
--- a/src/chatView.js
+++ b/src/chatView.js
@@ -613,8 +613,12 @@ const ChatView = new Lang.Class({
         }
     },
 
+    _getNickTagName: function(nick) {
+        return NICKTAG_PREFIX + nick;
+    },
+
     _setNickStatus: function(nick, status) {
-        let nickTag = this._lookupTag('nick' + nick);
+        let nickTag = this._lookupTag(this._getNickTagName(nick));
         if (!nickTag)
            return;
 
@@ -910,10 +914,11 @@ const ChatView = new Lang.Class({
         } else {
             if (state.lastNick != message.nick) {
                 let tags = [this._lookupTag('nick')];
-                let nickTag = this._lookupTag(NICKTAG_PREFIX + message.nick);
+                let nickTagName = this._getNickTagName(message.nick);
+                let nickTag = this._lookupTag(nickTagName);
 
                 if (!nickTag) {
-                    nickTag = new Gtk.TextTag({ name: NICKTAG_PREFIX + message.nick });
+                    nickTag = new Gtk.TextTag({ name: nickTagName });
                     this._view.get_buffer().get_tag_table().add(nickTag);
                 }
                 tags.push(nickTag);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]