[epiphany/gnome-3-16] Fix clearing all passwords from the clear data dialog



commit 21004a7c0e7373a65a758057e7c5265d44629de1
Author: Michael Catanzaro <mcatanzaro igalia com>
Date:   Fri Sep 18 11:54:17 2015 -0500

    Fix clearing all passwords from the clear data dialog
    
    Epiphany saves passwords with EPHY_FORM_PASSWORD_SCHEMA. If we want to
    delete the passwords we've saved, we have to pass that schema to
    libsecret. Using the SECRET_SCHEMA_COMPAT_NETWORK guarantees we will
    only delete passwords saved by other apps, and none of our own
    passwords.
    
    Exception: WebKitGTK+ is saving HTTP auth passwords with
    SECRET_SCHEMA_COMPAT_NETWORK. This change means those passwords will no
    longer be deleted, which is non-ideal.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=755190

 src/clear-data-dialog.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/clear-data-dialog.c b/src/clear-data-dialog.c
index cad5b4b..6286142 100644
--- a/src/clear-data-dialog.c
+++ b/src/clear-data-dialog.c
@@ -28,6 +28,7 @@
 #include <libsecret/secret.h>
 #include <webkit2/webkit2.h>
 
+#include "ephy-form-auth-data.h"
 #include "ephy-history-service.h"
 #include "ephy-embed-shell.h"
 
@@ -77,8 +78,8 @@ delete_all_passwords (ClearDataDialog *dialog)
 {
        GHashTable *attributes;
 
-       attributes = secret_attributes_build (SECRET_SCHEMA_COMPAT_NETWORK, NULL);
-       secret_service_clear (NULL, SECRET_SCHEMA_COMPAT_NETWORK,
+       attributes = secret_attributes_build (EPHY_FORM_PASSWORD_SCHEMA, NULL);
+       secret_service_clear (NULL, EPHY_FORM_PASSWORD_SCHEMA,
                              attributes, NULL,
                              (GAsyncReadyCallback)secret_service_clear_finish,
                              NULL);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]